Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for non-integer user id in the shell adapter. #1117

Closed
kengz opened this issue Jan 12, 2016 · 2 comments
Closed

Allow for non-integer user id in the shell adapter. #1117

kengz opened this issue Jan 12, 2016 · 2 comments

Comments

@kengz
Copy link

kengz commented Jan 12, 2016

Under hubot/src/adapters/shell.coffee line 45, the user id is parsed as integer. For generality, can we remove the parseInt and allow for string type id? Many adapters and chat clients use non-integers too.
@technicalpickles
Copy link
Member

That is what I'm proposing in #1052

@kengz
Copy link
Author

kengz commented Jan 13, 2016

@technicalpickles my bad; didn't see that when I was searching for the issue.

@kengz kengz closed this as completed Jan 13, 2016
@technicalpickles technicalpickles mentioned this issue Jan 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@technicalpickles @kengz