Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node up to v4.2 to travis. Add intellij stuff to gitignore #1068

Merged
merged 5 commits into from
Oct 22, 2015

Conversation

scboucher
Copy link
Contributor

See issue #1050

@scboucher scboucher mentioned this pull request Oct 13, 2015
- node_js: "0.10"
- node_js: "0.12"
- node_js: "4.0"
- node_js: "4.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are odd releases still considered 'unstable'? If so, I don't think we need to include that here.

@scboucher
Copy link
Contributor Author

Maybe we could only include v4.2.* since it is the LTS version. But there is no more unstable release. Instead odd version are not LTS.
https://nodesource.com/assets/blog/essential-steps-lts/nodejs_lts_schedule.png
https://nodejs.org/en/blog/release/v4.2.1/
https://nodesource.com/blog/essential-steps-long-term-support-for-nodejs

fail 0.8

fail 0.8

Only last node v4
@scboucher
Copy link
Contributor Author

I thought about it, maybe the best solution is to only target node v4. I don't believe there will be any major change between v4.2.X and v5.
Then the question is should Hubot support only lts version or all of them.

I'll try to investigate the v0.8 problem it seems to be related to npm. But for now I think it is the best to allow failure on this version.

Samuel Boucher added 2 commits October 22, 2015 09:28
@scboucher
Copy link
Contributor Author

Removed node v0.8 cc #1070

@michaelansel
Copy link
Collaborator

I'm a fan. I don't normally like adding IDE files to the git ignore (should be using a local global ignore for that), but I'll let it go as long as @technicalpickles doesn't object.

@michaelansel
Copy link
Collaborator

👍

michaelansel added a commit that referenced this pull request Oct 22, 2015
Add node up to v4.2 to travis. Add intellij stuff to gitignore
@michaelansel michaelansel merged commit c355911 into hubotio:master Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants