Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only loadScripts once #1069

Merged
merged 2 commits into from
Nov 12, 2015
Merged

Only loadScripts once #1069

merged 2 commits into from
Nov 12, 2015

Conversation

technicalpickles
Copy link
Member

This should fix slackapi/hubot-slack#210 over in hubot-slack. I'm not sure if there's any other implications of this, like if other adapters have workarounds for this or not.

@michaelansel
Copy link
Collaborator

First pass says this should be fine. I don't think we ever intentionally reload scripts.

@zapbuild
Copy link

When you are going to merge it into master branch? I'm getting the same issue "Hubot repeating himself twice after reconnect". I'm using hubot-slack adapter.

@technicalpickles
Copy link
Member Author

Soon. I'm testing this branch in production, and hoping to verify the double-response is fixed.

@technicalpickles
Copy link
Member Author

I still have this out in production. There weren't any reconnect events to verify this fixes it yet though 😓

@ThomasRooney
Copy link

I can verify that this has fixed my issue with multiple responses after a reconnect. Can we get it merged?

bhuga pushed a commit that referenced this pull request Nov 12, 2015
@bhuga bhuga merged commit 6795a30 into master Nov 12, 2015
@bhuga bhuga deleted the only-load-scripts-once branch November 12, 2015 20:35
@Floby
Copy link

Floby commented Nov 12, 2015

\o/
Le 12 nov. 2015 21:35, "Ben Lavender" notifications@github.com a écrit :

Merged #1069 #1069.


Reply to this email directly or view it on GitHub
#1069 (comment).

@Floby
Copy link

Floby commented Nov 19, 2015

I take it this has been published with 2.17.0 ?

@bhuga
Copy link
Contributor

bhuga commented Nov 19, 2015

Yes, this is in 2.17.0.

@Floby
Copy link

Floby commented Nov 19, 2015

ok, thanks a lot =)

On 19 November 2015 at 15:52, Ben Lavender notifications@github.com wrote:

Yes, this is in 2.17.0.


Reply to this email directly or view it on GitHub
#1069 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If hubot reconnects due to a slow system, it answers messages twice
6 participants