-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only loadScripts once #1069
Only loadScripts once #1069
Conversation
First pass says this should be fine. I don't think we ever intentionally reload scripts. |
When you are going to merge it into master branch? I'm getting the same issue "Hubot repeating himself twice after reconnect". I'm using hubot-slack adapter. |
Soon. I'm testing this branch in production, and hoping to verify the double-response is fixed. |
I still have this out in production. There weren't any reconnect events to verify this fixes it yet though 😓 |
I can verify that this has fixed my issue with multiple responses after a reconnect. Can we get it merged? |
\o/
|
I take it this has been published with |
Yes, this is in |
ok, thanks a lot =) On 19 November 2015 at 15:52, Ben Lavender notifications@github.com wrote:
|
This should fix slackapi/hubot-slack#210 over in hubot-slack. I'm not sure if there's any other implications of this, like if other adapters have workarounds for this or not.