Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shell] don't color hubot responses green, to be more visible on light backgrounds #1111

Merged
merged 1 commit into from
Jan 20, 2016

Conversation

technicalpickles
Copy link
Member

This is a possible fix for #1102

cc @glensc

@glensc
Copy link

glensc commented Jan 9, 2016

👍

technicalpickles added a commit that referenced this pull request Jan 20, 2016
[shell] don't color hubot responses green, to be more visible on light backgrounds
@technicalpickles technicalpickles merged commit cb9ddb1 into master Jan 20, 2016
@technicalpickles technicalpickles deleted the shell-bold-no-green branch January 20, 2016 03:37
@technicalpickles technicalpickles mentioned this pull request Jan 20, 2016
@technicalpickles
Copy link
Member Author

I have a feeling I'll want to revisit this because the bold text doesn't really stand out without color. Maybe have environment variable like HUBOT_SHELL_OUTPUT_COLOR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants