Adopt Elm language package to elm-community #3027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original package author deadfoxygrandpa is currently unresponsive. Therefore elm-community has cloned his great package to be able to adapt new grammar introduced in Elm 0.17.
|
Maybe foxygrandpa's dead. (Sorry, somebody had to say it...) |
|
I was just about to open up an issue about this. +1 |
|
@ThomasWeiser - it's a little more involved than just this change. I've opened an updated PR here: #3033 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On behalf of elm-community I ask you to use elm-community's clone of
Elm.tmLanguage.The original author Alex Neslusan @deadfoxygrandpa is unresponsive since 2016-04-10.
There is a syntax change in Elm language version 0.17 that needs to be reflected in the package's grammar rules. The existing grammar renders most of the new Elm 0.17 source code red for being illegal.
On 2016-04-06 the language creator @evancz asked deadfoxygrandpa to update his package for the new syntax. Four days later deadfoxygrandpa promised to do it. Since then deadfoxygrandpa wasn't seen on GitHub or on Elm's mailing lists elm-discuss and elm-dev.
See this PR for the pending update and corresponding discussion.