Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm support #137

Closed
theoephraim opened this issue Jan 7, 2025 · 4 comments
Closed

pnpm support #137

theoephraim opened this issue Jan 7, 2025 · 4 comments
Assignees

Comments

@theoephraim
Copy link
Contributor

It seems that if I'm using pnpm instead of npm, the inputs are no longer being loaded correctly.

I wanted to use pnpm because of how it handles link: style package dependencies for testing with local deps.

@ncalteen
Copy link
Collaborator

ncalteen commented Jan 7, 2025

Do you have a repo you can share with your setup? I'd be happy to take a look

@ncalteen ncalteen self-assigned this Jan 7, 2025
@theoephraim
Copy link
Contributor Author

theoephraim commented Jan 8, 2025

so one issue seems to be using npx within bin/local-action.js. One possible fix is using the binary path directly

const tsxPath = resolve(__dirname, '../node_modules/.bin/tsx')
let command = `${tsxPath} "${path.join(packagePath, 'src', 'index.ts')}"`

Although things can get a little weird with yarn pnp, because it doesnt create node_modules by default.

Another option is detecting the current package manager and calling pnpm exec/yarn exec etc...

@ncalteen
Copy link
Collaborator

Sorry for the radio silence on this! Its still on my radar...just getting pulled in a few directions. After some testing I can make this work with the exception of yarn pnp. That might take some more work...

@ncalteen
Copy link
Collaborator

ncalteen commented Mar 3, 2025

👋🏻 hello again! I have just merged in and released version 3.0.0 of @github/local-action. Feel free to give it a try and let me know if things seem to be working well! If you see any problems, please open a new issue or comment on this one.

I took a bit of extra time to find a solution for yarn pnp support :)

@ncalteen ncalteen closed this as completed Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants