Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoctor include:: doesn't seem to be usable for github repos #335

Closed
mikolak-net opened this issue Jul 17, 2014 · 3 comments
Closed

Comments

@mikolak-net
Copy link

The include directive in asciidoctor documents doesn't seem to be usable at the moment for readme, it fails both when:

  • attempting to use the "raw" URL, probably due to this and/or a higher safety mode used.
  • attempting to use a relative path also fails (example here ).

Is there any possibility of a workaround/fix?

@mikolak-net mikolak-net changed the title include:: doesn't seem to be usable for github repos asciidoctor include:: doesn't seem to be usable for github repos Jul 17, 2014
@gjtorikian
Copy link
Contributor

Due to potential security issues, include:: is not supported by GitHub at this time. We don't know if or when we'll add such a feature, but I've added your request to our internal feature request list.

@mikolak-net
Copy link
Author

@gjtorikian re inherent insecurity of include directives, completely understable, given how my background includes PHP ;).

Nevertheless, I think properly pre-sanitized includes limited to only, say, files in the same repo (or same user's repos) would be safe enough, so 👍 on the add.

@mojavelinux
Copy link
Contributor

We're tracking this request from the Asciidoctor side.

asciidoctor/asciidoctor#1088

We need to do some planning and negotiating first, then we can possibly move forwards with an implementation. The limitations have to do as much about security as they are technical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants