Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Double escaping of facts not implemented for puppet master endpoint #31

Closed
kpaulisse opened this issue Dec 7, 2016 · 1 comment
Labels

Comments

@kpaulisse
Copy link
Contributor

Citing https://docs.puppet.com/puppet/latest/http_api/http_catalog.html#parameters:

facts: serialized pson of the facts hash. One odd note: due to a long-ago misunderstanding in the code, this is doubly-escaped (it should just be singly-escaped). To keep backward compatibility, the extraneous escaping is still used/supported.

The current code only single-escapes the facts hash. We need to break the code to double-escape it, or else literal + will be converted to spaces and in some cases % followed by 2 characters might get translated into a random character.

Note that this only affects Fetching catalogs from Puppet Master / PuppetServer

@kpaulisse kpaulisse added the bug label Dec 7, 2016
@kpaulisse
Copy link
Contributor Author

Fixed by #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant