Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema Inaccuracy] Incorrect "required" key #27

Closed
SOF3 opened this issue Aug 14, 2020 · 1 comment
Closed

[Schema Inaccuracy] Incorrect "required" key #27

SOF3 opened this issue Aug 14, 2020 · 1 comment
Labels
inaccuracy

Comments

@SOF3
Copy link

SOF3 commented Aug 14, 2020

Schema Inaccuracy

https://github.com/github/rest-api-description/blob/a6c95e025223022e1522b7e6e6ed32d08aa8dd9e/descriptions/api.github.com/api.github.com.json#L50682-L50684

JSON path: components.schemas.event.properties.payload.properties.pages.required

This refers to an array type schema, which should not have the required key. Are these three lines supposed to be moved two lines down (i.e. applied on event.properties.payload) or one line up (i.e. applied on event.properties.payload.pages.items?
@xuorig
Copy link

xuorig commented Aug 21, 2020

Good catch, thanks @SOF3. This was fixed on the latest main. 🙇

@xuorig xuorig closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inaccuracy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuorig @SOF3