Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Inaccuracy] Min-Items part of String, but should be array #3926

Closed
hfhbd opened this issue Sep 2, 2024 · 1 comment
Closed

[Schema Inaccuracy] Min-Items part of String, but should be array #3926

hfhbd opened this issue Sep 2, 2024 · 1 comment

Comments

@hfhbd
Copy link

hfhbd commented Sep 2, 2024

Schema Inaccuracy

/user/emails/delete and /user/emails/post both contains:

"properties": {
  "emails": {
    "description": "Adds one or more email addresses to your GitHub account. Must contain at least one email address. **Note:** Alternatively, you can pass a single email address or an `array` of emails addresses directly, but we recommend that you pass an object using the `emails` key.",
    "type": "array",
    "items": {
      "type": "string",
      "example": "username@example.com",
      "minItems": 1
     },
     "example": []
  }
}

Expected

The minItems should be part of the array, not the string.

"properties": {
  "emails": {
    "description": "Adds one or more email addresses to your GitHub account. Must contain at least one email address. **Note:** Alternatively, you can pass a single email address or an `array` of emails addresses directly, but we recommend that you pass an object using the `emails` key.",
    "type": "array",
    "items": {
      "type": "string",
      "example": "username@example.com"
     },
     "minItems": 1
     "example": []
  }
}

Reproduction Steps

@shiftkey
Copy link
Member

@hfhbd this has been resolved - please confirm the current schema matches what you were expecting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants