Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Support for VS Code Actions Extension #189

Open
thomasphorton opened this issue May 10, 2023 · 12 comments
Open

Proxy Support for VS Code Actions Extension #189

thomasphorton opened this issue May 10, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@thomasphorton
Copy link

Is your feature request related to a problem? Please describe.
Morgan Stanley users receive an error when using the Actions extension for VSCode, blocking them from using the Intellisense features of the extension.

request to https://api.github.com/user failed, reason: connect EHOSTUNREACH 192.30.255.116:443

They have an enterprise proxy in place, and have configured the VSCode proxy settings. It appears that the extension does not pull from these proxy settings and is failing to connect.

% cat .vscode-settings.json | grep proxy
"http.proxy": http://proxy-app.ms.com:8080/,
"https.proxy": http://proxy-app.ms.com:8080/,

Describe the solution you'd like
Check for proxy configuration and use those settings if applicable for any connection to external resources.

Additional context
Slack thread

@RockyMM
Copy link

RockyMM commented Jul 14, 2023

Possibly duplicate of #143?

Anyways, is this a good "first issue" for a new contributor?

@RockyMM
Copy link

RockyMM commented Aug 8, 2023

I guess this could be implemented with https://github.com/octokit/octokit.js#proxy-servers-nodejs-only and taking over proxy settings from the workspace.

However, to fully support all scenarios, #39 should be resolved too.

@andrewholler
Copy link

Need this

@DennisDyallo
Copy link

Please

@edward-nunez
Copy link

edward-nunez commented Feb 11, 2024

This addon is pointless behind a corporate proxy firewall. I tried every type of proxy configuration on my windows machine and VS Code and it still will not reach the Github API while the other Github Addons work fine like Github Pull Request.

Any work arounds until this gets addressed?

@RockyMM
Copy link

RockyMM commented Feb 12, 2024

Any work arounds until this gets addressed?

I fear you would have to reconfigure your machine so it passes around the corporate proxy when connections are initiated from VSCode to GitHub. Otherwise, only a PR would help here...

@KetchupOnMyKetchup
Copy link
Contributor

KetchupOnMyKetchup commented Feb 28, 2024

I just wanted to include the proxy support for Copilot announcement here so that we can try to re-use some of the implementation that they used when work begins: https://github.com/orgs/community/discussions/29127

I also wanted to say that we just added a note that OS certs and proxies aren't currently supported but are planned - https://github.com/github/vscode-github-actions?tab=readme-ov-file#supported-features (once these are completed we need to remove this note as well)

@KetchupOnMyKetchup KetchupOnMyKetchup changed the title Proxy Support for Language Server Proxy Support for VS Code Actions Extension Mar 1, 2024
@mo-ian-watkins
Copy link

It has been a year now, is there any movement on getting this done please?

Developing GitHub Actions can be hard work, especially in a corporate setting, where workflows are now being used as deployment pipelines. I for one, would like to use this extension in my workplace (behind a proxy) to make my life a little easier.

@micahlt
Copy link

micahlt commented Jun 12, 2024

A slightly different issue but I believe it has the same cause - this extension cannot function when connected to a remote machine in VSCode.

@itanex
Copy link

itanex commented Aug 6, 2024

Has there been any movement on this?

@o-az
Copy link

o-az commented Dec 11, 2024

on the "Uninstall" dropdown I installed another version: 0.26.5

now it works

CleanShot 2024-12-11 at 02 41 09@2x

@mo-ian-watkins
Copy link

v0.27.0 also working for me behind a corporate firewall. Hopefully it has been implemented rather than a happy accident 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Triaged 📝
Development

No branches or pull requests

11 participants