You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Opening a Workspace in VSCode with the GitHub Actions extension enabled connected to a GHES 3.7 will quickly consume all the quota available because the extension performs hundreds of failing attempts to get Variables (404 not found). This is because the Variables support was introduced on GHES 3.8. Therefore, all requests to get Variables will return 404.
To Reproduce
Steps to reproduce the behavior:
Log into a GitHub Enterprise server version 3.7 in VSCode
Open any workspace with workflows
Open the vscode-github-actions logs in VS Code
See several 404 errors trying to reach https://<ghes_url>/api/v3/repos/<user>/<repo>/actions/variables
Expected behavior
In one of my tests, the extension made 154 attempts to get Variables just by opening the workspace. I guess it's ok to try to get it once and stop. Or try to check if the server version has Variables available before making the request.
Screenshots
Here you can see one of the attempts of the log (sensitive data hidden by ***)
Additional context
It looks like the request attempts are even more aggressive when using SSH, e.g. using WSL. Typing an if statement in a workflow made almost 500 requests. Tested on GHES v3.7.5.
GHES is unfortunately not officially supported, and it is not currently on our roadmap. I'm closing this, because without robust GHES version handling we probably can't effectively handle this case.
Describe the bug
Opening a Workspace in VSCode with the GitHub Actions extension enabled connected to a GHES 3.7 will quickly consume all the quota available because the extension performs hundreds of failing attempts to get
Variables
(404 not found). This is because theVariables
support was introduced on GHES 3.8. Therefore, all requests to getVariables
will return 404.To Reproduce
Steps to reproduce the behavior:
https://<ghes_url>/api/v3/repos/<user>/<repo>/actions/variables
Expected behavior
In one of my tests, the extension made 154 attempts to get
Variables
just by opening the workspace. I guess it's ok to try to get it once and stop. Or try to check if the server version hasVariables
available before making the request.Screenshots
Here you can see one of the attempts of the log (sensitive data hidden by
***
)Extension Version
v0.26.2
Additional context
It looks like the request attempts are even more aggressive when using SSH, e.g. using WSL. Typing an
if
statement in a workflow made almost 500 requests. Tested on GHES v3.7.5.Might be related to #192
I hope this can be easily fixed. The extension is amazing and I'd be really happy to use it at its full potential :)
The text was updated successfully, but these errors were encountered: