Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: Remove our dependency on the CustomElement vendor module #5156

Open
githubbob42 opened this issue May 4, 2019 · 0 comments
Open

Comments

@githubbob42
Copy link
Owner

Mingle Card: 5511
Description

We currently have two bindings dependent on the CustomElement polyfill:  geolocation and reference.  The polyfill was written for the Google only api (beta) called “Custom Elements v0”.  A latter implementation which is supported by new browsers called “Custom Elements v1” is better supported.   It’s debatable as to whether we even needed Custom Element interface in the first place.

Acceptance Criteria

The selenium suite should pass as normal.

Analysis

In order to use the v1 of CustomElements, we need to use version 6(?) of babel (babel/babel#4480) although there appears to be the possibility of using a shim, WICG/webcomponents#587 (specifically, WICG/webcomponents#587 (comment)) but there seems to be questions still regarding this.

I think we need to get our build/babel issues worked/ironed out first before we can decide which direction to go.  

Maybe just updating out v0 to a more recent v0 is an option for the near term. 

Related Stories

Tasks

{{ table query: SELECT Number, Name, Owner, 'Task Status' WHERE Type = Task and Story = THIS CARD ORDER BY Status }}

Defects

{{ table query: SELECT Number, Name, Owner, 'Status' WHERE Type = Defect and 'Related Story' = THIS CARD }}

Test Plan

Test this on physical iPad and Android.

All geolocation fields will be affected and all fields that are lookups. For example, the Account field on Job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant