Skip to content

[log] Add debug logging to internal/server/transport.go #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Jan 15, 2026
Merged

[log] Add debug logging to internal/server/transport.go #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/server/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,16 @@ import (
sdk "github.com/modelcontextprotocol/go-sdk/mcp"
)

var logTransport = logger.New("server:transport")

// HTTPTransport wraps the SDK's HTTP transport
type HTTPTransport struct {
Addr string
}

// Start implements sdk.Transport interface
func (t *HTTPTransport) Start(ctx context.Context) error {
logTransport.Printf("Starting HTTP transport: addr=%s", t.Addr)
// The SDK will handle the actual HTTP server setup
// We just need to provide the address
log.Printf("HTTP transport ready on %s", t.Addr)
Expand Down Expand Up @@ -76,6 +79,7 @@ func withResponseLogging(handler http.Handler) http.Handler {
// CreateHTTPServerForMCP creates an HTTP server that handles MCP over streamable HTTP transport
// If apiKey is provided, all requests except /health require authentication (spec 7.1)
func CreateHTTPServerForMCP(addr string, unifiedServer *UnifiedServer, apiKey string) *http.Server {
logTransport.Printf("Creating HTTP server for MCP: addr=%s, auth_enabled=%v", addr, apiKey != "")
mux := http.NewServeMux()

// OAuth discovery endpoint - return 404 since we don't use OAuth
Expand All @@ -85,6 +89,7 @@ func CreateHTTPServerForMCP(addr string, unifiedServer *UnifiedServer, apiKey st
})
mux.Handle("/mcp/.well-known/oauth-authorization-server", withResponseLogging(oauthHandler))

logTransport.Print("Registering streamable HTTP handler for MCP protocol")
// Create StreamableHTTP handler for MCP protocol (supports POST requests)
// This is what Codex uses with transport = "streamablehttp"
streamableHandler := sdk.NewStreamableHTTPHandler(func(r *http.Request) *sdk.Server {
Expand All @@ -110,6 +115,7 @@ func CreateHTTPServerForMCP(addr string, unifiedServer *UnifiedServer, apiKey st

// Reject requests without Authorization header
if sessionID == "" {
logTransport.Printf("Rejecting connection: no Authorization header, remote=%s, path=%s", r.RemoteAddr, r.URL.Path)
logger.LogErrorMd("client", "MCP connection rejected: no Authorization header, remote=%s, path=%s", r.RemoteAddr, r.URL.Path)
log.Printf("[%s] %s %s - REJECTED: No Authorization header", r.RemoteAddr, r.Method, r.URL.Path)
// Return nil to reject the connection
Expand Down Expand Up @@ -163,6 +169,7 @@ func CreateHTTPServerForMCP(addr string, unifiedServer *UnifiedServer, apiKey st

// Close endpoint for graceful shutdown (spec 5.1.3)
closeHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
logTransport.Printf("Close endpoint called: method=%s, remote=%s", r.Method, r.RemoteAddr)
log.Printf("[%s] %s %s", r.RemoteAddr, r.Method, r.URL.Path)
logger.LogInfo("shutdown", "Close endpoint called, remote=%s", r.RemoteAddr)

Expand All @@ -185,6 +192,7 @@ func CreateHTTPServerForMCP(addr string, unifiedServer *UnifiedServer, apiKey st

// Initiate shutdown and get server count
serversTerminated := unifiedServer.InitiateShutdown()
logTransport.Printf("Shutdown initiated: servers_terminated=%d", serversTerminated)

// Return success response (spec 5.1.3)
w.Header().Set("Content-Type", "application/json")
Expand Down