Fix: Skip already-closed discussions in expiration workflow

[Copilot]

The close_expired_discussions script was attempting to process discussions that had been closed between the initial search (which filters for OPEN state) and the processing phase, resulting in comments being added to closed discussions.

Changes

• Modified hasExpirationComment() to return {hasComment, isClosed} instead of boolean

  • Fetches closed field in GraphQL query alongside comment check

• Added closed state guard in processing loop

  • Skip discussions where isClosed === true before attempting any operations

• Updated test coverage to verify closed discussions are skipped

// Before: Only checked for duplicate comments
const hasComment = await hasExpirationComment(github, discussion.id);
if (hasComment) {
  await closeDiscussionAsOutdated(github, discussion.id); // Could fail if already closed
}

// After: Check closed state first
const { hasComment, isClosed } = await hasExpirationComment(github, discussion.id);
if (isClosed) {
  continue; // Skip entirely
}

The fix eliminates the race condition window where discussions closed by other processes would still be processed.

Original prompt

Review the agentic maintenance code that closes expired discussions.

It should not be adding comments to discussions who are already closed.

See this comment #10338 (comment) which was added a closed discussion.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.