Completely remove timeout_minutes - use codemod to migrate#12702
Merged
Completely remove timeout_minutes - use codemod to migrate#12702
Conversation
7 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove duplicate timeout_minutes from workflow schema
Remove duplicate timeout_minutes from schema while maintaining runtime support
Jan 30, 2026
Contributor
|
@copilot completely remote timeout_minutes, there is a codemod |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done! Completely removed Changes in commit 4a26aa3:
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Remove duplicate timeout_minutes from schema while maintaining runtime support
Completely remove timeout_minutes - use codemod to migrate
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main workflow schema defined both
timeout-minutesandtimeout_minutesas separate properties. This created schema pollution and unnecessary API surface for the same functionality.Per feedback,
timeout_minuteshas been completely removed from both schema and runtime. Users can migrate their workflows using the existingtimeout-minutes-migrationcodemod.Changes
Schema cleanup
timeout_minutesfrompkg/parser/schemas/main_workflow_schema.jsontimeout-minutesremains as the only schema-defined fieldtimeout_minutesnow fail validation with "additional properties not allowed"Runtime removal
compiler_orchestrator_workflow.go(no longer checks fortimeout_minutes)claude_engine.goandcopilot_engine_execution.gotools.goto usetimeout-minutesinstead oftimeout_minutesjobs.goto referencetimeout-minutesTest updates
pkg/workflow/timeout_minutes_test.go(obsolete test file)timeout_minutesMigration Path
Users with existing workflows using
timeout_minutesshould run:The
timeout-minutes-migrationcodemod will automatically converttimeout_minutestotimeout-minuteswhile preserving comments and formatting.Behavior
Workflows using
timeout_minuteswill now fail validation:Use the canonical form instead:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.