Fix dispatch_workflow tools registration in safe-outputs MCP server#12886
Merged
Fix dispatch_workflow tools registration in safe-outputs MCP server#12886
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Modified registerPredefinedTools to detect and register dispatch_workflow tools - Added check for tools with _workflow_name metadata - Added comprehensive tests for dispatch_workflow tool registration - Verified fix with test workflow compilation Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- All JavaScript tests passing (3162 tests) - All Go tests passing for dispatch_workflow - Formatting and linting validated - End-to-end workflow compilation tested Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Added explicit permissions: contents: read - Fixed CodeQL security alert about missing workflow permissions - Recompiled test-dispatcher workflow Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with dispatch_workflow in safe-outputs
Fix dispatch_workflow tools registration in safe-outputs MCP server
Jan 31, 2026
mnkiefer
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dispatch_workflowsafe-output generates dynamic tools with workflow-specific names (test_workflowfor workflowtest-workflow), butregisterPredefinedToolsonly registered tools matching config keys. Sincetest_workflow≠dispatch_workflow, tools were silently skipped.Changes
actions/setup/js/safe_outputs_tools_loader.cjs: Added check for tools with_workflow_namemetadata whendispatch_workflowexists in configactions/setup/js/safe_outputs_tools_loader.test.cjs: Added 5 tests covering dynamic tool registration and handler attachmentExample
Tools with
_workflow_namemetadata are now registered:Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.