Skip to content

[security-fix] Fix unsafe quoting in secret redaction YAML generation (Alert #10) #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Oct 11, 2025
Merged

[security-fix] Fix unsafe quoting in secret redaction YAML generation (Alert #10) #1520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/workflow/redact_secrets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ func (c *Compiler) generateSecretRedactionStep(yaml *strings.Builder, yamlConten
for _, secretName := range secretReferences {
// Escape secret name to prevent injection in YAML
escapedSecretName := escapeSingleQuote(secretName)
yaml.WriteString(fmt.Sprintf(" SECRET_%s: ${{ secrets.%s }}\n", escapedSecretName, escapedSecretName))
// Use original secretName in GitHub Actions expression since it's already validated
// to only contain safe characters (uppercase letters, numbers, underscores)
yaml.WriteString(fmt.Sprintf(" SECRET_%s: ${{ secrets.%s }}\n", escapedSecretName, secretName))
}
}

Expand Down
Loading