Skip to content

[security-fix] Security Fix: Allocation Size Overflow in Environment Key Collection (Alert #20) #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Oct 15, 2025
Merged

[security-fix] Security Fix: Allocation Size Overflow in Environment Key Collection (Alert #20) #1765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/workflow/mcp-config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,12 @@ func renderSharedMCPConfig(yaml *strings.Builder, toolName string, toolConfig ma
}
fmt.Fprintf(yaml, "%s\"env\": {\n", renderer.IndentLevel)

// Collect all env keys (both existing and header secrets)
envKeys := make([]string, 0, len(mcpConfig.Env)+len(headerSecrets))
// CWE-190: Allocation Size Overflow Prevention
// Instead of pre-calculating capacity (len(mcpConfig.Env)+len(headerSecrets)),
// which could overflow if the maps are extremely large, we let Go's append
// handle capacity growth automatically. This is safe and efficient for
// environment variable maps which are typically small in practice.
var envKeys []string
for key := range mcpConfig.Env {
envKeys = append(envKeys, key)
}
Expand Down
Loading