Remove js-yaml dependency from badge generator, use regex-based parsing#2108
Merged
Remove js-yaml dependency from badge generator, use regex-based parsing#2108
Conversation
- Remove js-yaml import dependency - Implement regex-based YAML name field parsing - Support quoted and unquoted name values - Tested with all 42 workflow lock files successfully Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
Copilot
AI
changed the title
[WIP] Remove js-yml dependency in badge generator
Remove js-yaml dependency from badge generator, use regex-based parsing
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
scripts/generate-status-badges.jsscript was importingjs-yamlto parse workflow lock files and extract thenamefield. However, this dependency was not installed in the project, causing the script to fail when executed:See: https://github.com/githubnext/gh-aw/actions/runs/18710130246/job/53356355485#step:5:1
Solution
Replaced the
js-yamldependency with a simple regex-based parser that extracts thename:field directly from the YAML content. Since the badge generator only needs to read a single field from each workflow file, a full YAML parser is unnecessary overhead.Implementation
The new approach uses a regex pattern to match the workflow name:
/^name:\s*["']?([^"'\n]+?)["']?\s*$/mThis pattern:
name:at the start of a lineBefore:
After:
Benefits
js-yamlTesting
Verified the script works correctly:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/githubnext/gh-aw/actions/runs/18710130246/jobscurl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.