Move validation functions from compiler.go to validation.go#2396
Merged
Move validation functions from compiler.go to validation.go#2396
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move validation functions to validation.go for better organization
Move validation functions from compiler.go to validation.go
Oct 25, 2025
pelikhan
approved these changes
Oct 25, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR relocates three validation functions from compiler.go to validation.go to improve code organization and separation of concerns. The functions are moved without modification, maintaining their *Compiler receivers and exact signatures.
- Moved
validateHTTPTransportSupport(),validateMaxTurnsSupport(), andvalidateWebSearchSupport()tovalidation.go - All required imports (
fmt,os,console) already exist invalidation.go - Function calls in
compiler.goremain unchanged
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/validation.go | Added three validation functions for HTTP transport, max-turns, and web-search support |
| pkg/workflow/compiler.go | Removed the same three validation functions that were relocated to validation.go |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2388. Semantic function clustering analysis identified validation functions scattered across files. Three validation methods in
compiler.gobelong invalidation.gowith related validation logic.Changes
validateHTTPTransportSupport()from compiler.go (line 2949) to validation.go (line 451)validateMaxTurnsSupport()from compiler.go (line 2968) to validation.go (line 470)validateWebSearchSupport()from compiler.go (line 2992) to validation.go (line 494)All functions retain their
*Compilerreceiver and exact signatures. All required imports (fmt,os,console) already present in validation.go. Function calls in compiler.go unchanged.Net change: -60 lines compiler.go, +60 lines validation.go
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.