Add catch-all matrix groups for CLI and Parser integration tests #6566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: 668 integration tests (86.3% of CLI, 89.7% of Parser) were silently skipped in CI because they didn't match any specific test pattern.
Changes:
Added two catch-all groups with empty patterns to ensure 100% test coverage:
Impact:
TestCompletion*Integration,TestSafeInputsMCPServer*, etc.)TestFrontmatterLocationIntegration,TestValidateWithSchemaAndLocation_PreciseLocation, etc.)All packages now follow the recommended pattern: specific groups for parallelization + catch-all for completeness.
Original prompt
This section details on the original issue you should resolve
<issue_title>[ci-coach] Fix critical test coverage gaps - add catch-all matrix groups</issue_title>
<issue_description>## CI Test Coverage Fix
Summary
CRITICAL: Discovered that 19 integration tests (28.6% of CLI tests and 45.5% of Parser tests) were NOT being executed by any CI job due to missing catch-all matrix groups. This PR adds two catch-all groups to ensure 100% test coverage.
Problem Identified
The CI matrix strategy uses specific test patterns to split tests across parallel jobs. However, two packages lacked catch-all groups (empty pattern
""), causing tests that don't match any specific pattern to be silently skipped:Missing CLI Tests (14 tests):
TestCompletion*Integration(9 tests)TestSafeInputsMCPServer*(4 tests)TestMainMissing Parser Tests (5 tests):
TestFrontmatterLocationIntegrationTestFrontmatterOffsetCalculationTestImprovementComparisonTestLocateJSONPathInYAML_RealExampleTestValidateWithSchemaAndLocation_PreciseLocationChanges Made
Added two new matrix groups with empty patterns (catch-all):
1. CLI Completion & Safe Inputs (line 91-93)
2. Parser Location & Validation (line 121-123)
Impact
Type: Test Coverage Fix
Impact: CRITICAL
Risk: LOW
Time Impact: +2-3 minutes per CI run (running previously skipped tests)
Benefits:
Matrix Strategy
The workflow now properly implements the recommended pattern for test splitting:
Packages with ONLY catch-all (run all tests):
./cmd/gh-aw- 1 groupPackages with specific patterns + catch-all (split tests, ensure none skipped):
./pkg/cli- 6 groups (5 specific + 1 catch-all) ✅./pkg/workflow- 13 groups (12 specific + 1 catch-all) ✅./pkg/parser- 2 groups (1 specific + 1 catch-all) ✅Total matrix groups: 21 (was 19)
Validation
✅ YAML syntax validated
✅ Catch-all groups confirmed present
✅ Matrix entries increased from 19 to 21
✅ No build/test failures expected (only adds missing tests)
Context
This issue was discovered during CI Coach workflow run #15 analysis. Previous runs (#13, #14) optimized parallelization and matrix balance but did not catch the coverage gaps because they focused on performance rather than correctness.
Testing Plan
After merge:
References:
Proposed by CI Coach workflow run #15
Show patch preview (47 of 47 lines)