Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno should be run with colored terminal logging output turned off #48

Closed
grempe opened this issue Jun 17, 2021 · 2 comments · Fixed by #51
Closed

Deno should be run with colored terminal logging output turned off #48

grempe opened this issue Jun 17, 2021 · 2 comments · Fixed by #51
Labels
enhancement New feature or request

Comments

@grempe
Copy link

grempe commented Jun 17, 2021

Logging of Deno errors on Github Actions tabs currenty logs Deno output with messy colored terminal output that can't be rendered in the github log tailing UI.

https://share.getcloudapp.com/GGuWQrnk

The deno command should be run with color disabled as described in the docs here:

https://deno.land/manual/getting_started/setup_your_environment#environmental-variables

@irealva
Copy link
Contributor

irealva commented Jul 12, 2021

Thanks for suggesting this.

Quick question: so we have the --allow-env flag enabled in our Deno run command. Are you not able to create an environment secret in your GitHub repo running the action with the variable name NO_COLOR and set to true? Does this not work?

@grempe
Copy link
Author

grempe commented Jul 12, 2021

The point is that deno should always be run without colored terminal output in the context of a Github action.

Not only if the developer pushing action code is aware of how to work around it. So IMHO it should be the default for flat

@irealva irealva added the enhancement New feature or request label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants