refactor: resolve sonar feedback re login fn (#1823)

setchy · web-flow · commit 01db9b16ccad · 2025-02-07T21:30:33.000-05:00
fix: sonar issue with login

Signed-off-by: Adam Setch &lt;adam.setch@outlook.com&gt;
diff --git a/src/renderer/routes/Login.tsx b/src/renderer/routes/Login.tsx
@@ -21,9 +21,9 @@ export const LoginRoute: FC = () => {
     }
   }, [isLoggedIn]);
 
-  const loginUser = useCallback(() => {
+  const loginUser = useCallback(async () => {
     try {
-      loginWithGitHubApp();
+      await loginWithGitHubApp();
     } catch (err) {
       logError('loginWithGitHubApp', 'failed to login with GitHub', err);
     }

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,9 @@ export const LoginRoute: FC = () => {`
`21`	`21`	`}`
`22`	`22`	`}, [isLoggedIn]);`
`23`	`23`
`24`		`- const loginUser = useCallback(() => {`
	`24`	`+ const loginUser = useCallback(async () => {`
`25`	`25`	`try {`
`26`		`- loginWithGitHubApp();`
	`26`	`+ await loginWithGitHubApp();`
`27`	`27`	`} catch (err) {`
`28`	`28`	`logError('loginWithGitHubApp', 'failed to login with GitHub', err);`
`29`	`29`	`}`