Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the code moves by activating git lens #179

Closed
agalera opened this issue Oct 24, 2017 · 6 comments
Closed

the code moves by activating git lens #179

agalera opened this issue Oct 24, 2017 · 6 comments
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature

Comments

@agalera
Copy link

agalera commented Oct 24, 2017

When changing files the code moves, it also happens when you switch between files.

Is it possible to reserve that space until the text appears to avoid this effect?

  • GitLens Version: 5.7.1

  • VSCode Version:
    Version 1.17.2
    Commit b813d12980308015bcd2b3a2f6efa5c810c33ba5
    Date 2017-10-16T13:57:00.652Z
    Shell 1.7.7
    Renderer 58.0.3029.110
    Node 7.9.0
    Architecture x64

  • OS Version:
    Linux T460 4.10.0-37-generic # 41~16.04.1-Ubuntu SMP Fri Oct 6 22:42:59 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:
https://www.youtube.com/watch?v=Ll7m4TvGqdA

@eamodio
Copy link
Member

eamodio commented Oct 24, 2017

@kianxineki When you say the code moves -- do you mean the code lens pushing the lines around?

I tried to look at the video, but it says it in unavailable :(

@agalera
Copy link
Author

agalera commented Oct 24, 2017

@eamodio yes

Video fixed :)

@eamodio eamodio added the blocked: vscode Caused by or dependent on a VS Code issue or feature label Oct 25, 2017
@eamodio
Copy link
Member

eamodio commented Oct 25, 2017

@kianxineki unfortunately that is just how vscode deals with code lens. You can turn off the GitLens code lens feature by default by setting "gitlens.codeLens.enabled": false

@agalera
Copy link
Author

agalera commented Oct 25, 2017

@eamodio I caught the attention when it happened to me, but I understand what he says. Do you know if it is in the vscode roadmap?

I will use that configuration until they solve it, very useful :)
Thanks for everything!

@eamodio
Copy link
Member

eamodio commented Oct 25, 2017

I'm not sure which part you have an issue with? The fact that code lens pop in or that each time you switch to a new tab they pop in all over again? I can't see anything really changing with the former because you don't want to delay the opening of a file to know where code lens will be rendered, but the latter I could see by them keeping a cache of the most recent opened files so that code lens doesn't need to be full re-evaluated.

I would encourage you to open an issue on the vscode github repo with what you'd like to see.

@github-actions
Copy link

github-actions bot commented Dec 7, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature
Projects
None yet
Development

No branches or pull requests

2 participants