Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovers display old Gravatar #1898

Closed
leo9-py opened this issue Mar 11, 2022 · 4 comments · Fixed by #1899
Closed

Hovers display old Gravatar #1898

leo9-py opened this issue Mar 11, 2022 · 4 comments · Fixed by #1899
Assignees
Labels
bug Something isn't working needs-verification Request for verification
Milestone

Comments

@leo9-py
Copy link
Contributor

leo9-py commented Mar 11, 2022

  • GitLens Version: v12.0.3
  • Git Version: 2.34.1.windows.1
  • VSCode Version: 1.65.2 x64
  • OS Version: Windows 10.0.19044.1526 LTSC

Using GitLens I noticed that the pop out Gravatar displayed is stale and not updating as fast as it should.

image

image

Steps to Reproduce:

  1. Update Gravatar on https://en.gravatar.com/
  2. Check pop out by hovering over blame line.
  3. Note that Gravatar is stale

I noticed that to alleviate this issue you can simply omit the '.jpg' in the request as GitLens sends a request (with my email hash) for
https://www.gravatar.com/avatar/e59f9ec19fc467009d1e4cea53f959cb.jpg?s=64&d=robohash
and not
https://www.gravatar.com/avatar/e59f9ec19fc467009d1e4cea53f959cb?s=64&d=robohash
for a faster change.

@eamodio
Copy link
Member

eamodio commented Mar 11, 2022

@amouxaden are you actually seeing a difference from gravatar itself, meaning if you update your image and you hit:
https://www.gravatar.com/avatar/e59f9ec19fc467009d1e4cea53f959cb.jpg?s=64&d=robohash
vs
https://www.gravatar.com/avatar/e59f9ec19fc467009d1e4cea53f959cb?s=64&d=robohash

You see a different version?

Or is this only in GitLens? I ask because GitLens caches avatars to avoid refreshing them often. I forget off hand for how long I cache them for before expiring them (but it's pretty long). You can always run the GitLens: Reset Avatar Cache from the Command Palette to make GitLens drop the cache and re-request the avatars.

@leo9-py
Copy link
Contributor Author

leo9-py commented Mar 11, 2022

@eamodio Yes precisely. I'm seeing a difference from the request that includes the .jpg vs the one that doesn't. It looks like this is a caching issue on Gravatars end but could possibly be resolved in the extension with omitting the file extension from the request.

Regarding the GitLens: Reset Avatar Cache, running from the command palette has no effect on my gravatar as I believe it reloads the old one again from gravatar with the file extension included.

After making a test build of GitLens with the file extension excluded, it was successfully able to load the most up to date version. I published this change with #1899

@eamodio
Copy link
Member

eamodio commented Mar 11, 2022

OK, awesome -- thank you so much for the investigation and PR! I will get that PR merged in for the next release. ❤️

@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Mar 11, 2022
@eamodio eamodio self-assigned this Mar 11, 2022
@eamodio eamodio added this to the Soon™ milestone Mar 11, 2022
@eamodio eamodio added needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Mar 14, 2022
@eamodio eamodio changed the title Blame line popout is displaying old Gravatar Hovers display old Gravatar Mar 14, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 17, 2022
@eamodio eamodio modified the milestones: Soon™, Shipped Mar 17, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants