Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git lens status bar entry has an incomprehensible accessibility label #1991

Closed
Neurrone opened this issue May 8, 2022 · 2 comments
Closed
Assignees
Labels
bug Something isn't working needs-verification Request for verification
Milestone

Comments

@Neurrone
Copy link

Neurrone commented May 8, 2022

Issue Type: Bug

I'm using VS Code with the NVDA screen reader.

For a few months now, the accessible label of the git lens icon which shows info about who last modified the current line that I'm on is incomprehensible. For example:

git-commit You, 3 months ago, ![You are offline](https://www.gravatar.com/avatar/d392bf2197c4efcb49eeeb0616e52e4e?s=64&d=robohash|width=32,height=32 "You are offline")![You are offline](data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSI0IiBoZWlnaHQ9IjE2IiB2aWV3Qm94PSIwIDAgNCAxNiI+Cgk8Y2lyY2xlIGN4PSIyIiBjeT0iMTQiIHI9IjIiIGZpbGw9IiNjZWNlY2UiLz4KPC9zdmc+ "You are offline")  __[You](mailto:dickson.tan.2013@gmail.com "Email You (dickson.tan.2013@gmail.com)")__, 3 months ago   _(February 20th, 2022 3:47 PM)_  > Add support for optional fetching of cover art --- [`$(git-commit) 1d702d9`](command:gitlens.showQuickCommitDetails?%7B%22sha%22%3A%221d702d944b8486010d8a9aaf2d64f6f892c0910d%22%7D "Show Commit")  [$(chevron-left)$(compare-changes)](command:gitlens.diffWith?%7B%22repoPath%22%3A%22d%3A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%22%2C%22lhs%22%3A%7B%22sha%22%3A%22beeb3c0b8b9e5a463a81b7b4ca27a54a5016a490%22%2C%22uri%22%3A%7B%22%24mid%22%3A1%2C%22path%22%3A%22%2Fd%3A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%2Faudible.py%22%2C%22scheme%22%3A%22file%22%7D%7D%2C%22rhs%22%3A%7B%22sha%22%3A%221d702d944b8486010d8a9aaf2d64f6f892c0910d%22%2C%22uri%22%3A%7B%22%24mid%22%3A1%2C%22path%22%3A%22%2Fd%3A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%2Faudible.py%22%2C%22scheme%22%3A%22file%22%7D%7D%2C%22line%22%3A2%7D "Open Changes with Previous Revision")   [$(versions)](command:gitlens.openFileRevision?%7B%22revisionUri%22%3A%7B%22%24mid%22%3A1%2C%22path%22%3A%22%2Fd%3A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%2Faudible.py%22%2C%22scheme%22%3A%22gitlens%22%2C%22authority%22%3A%227b22726566223a2262656562336330623862396535613436336138316237623463613237613534613530313661343930222c227265706f50617468223a22643a2f646f776e6c6f6164732f62656574732f706c7567696e732f61756469626c65227d%22%2C%22query%22%3A%22%7B%5C%22ref%5C%22%3A%5C%22beeb3c0%5C%22%7D%22%7D%2C%22line%22%3A2%2C%22annotationType%22%3A%22blame%22%7D "Open Blame Prior to this Change")   [$(globe)](command:gitlens.openCommitOnRemote?%7B%22sha%22%3A%221d702d944b8486010d8a9aaf2d64f6f892c0910d%22%7D "Open Commit on GitHub")   |   [$(plug) Connect to GitHub…](command:gitlens.connectRemoteProvider?%7B%22remote%22%3A%22github.com%2FNeurrone%2Fbeets-audible%22%2C%22repoPath%22%3A%22d%3A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%22%7D "Connect to GitHub to enable the display of the Pull Request (if any) that introduced this commit")   |   [$(organization) Team …](command:gitlens.action.hover.commands?%7B%22repoPath%22%3A%22d%3A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%22%2C%22commit%22%3A%7B%22sha%22%3A%221d702d944b8486010d8a9aaf2d64f6f892c0910d%22%2C%22author%22%3A%7B%22name%22%3A%22You%22%2C%22email%22%3A%22dickson.tan.2013%40gmail.com%22%2C%22presence%22%3A%7B%22status%22%3A%22offline%22%2C%22statusText%22%3A%22Offline%22%7D%7D%7D%2C%22file%22%3A%7B%22uri%22%3A%22file%3A%2F%2F%2Fd%253A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%2Faudible.py%22%2C%22line%22%3A2%7D%2C%22type%22%3A%22hover.commands%22%7D "Show Team Actions")   |   [$(ellipsis)](command:gitlens.showQuickCommitFileDetails?%7B%22revisionUri%22%3A%22gitlens%3A%2F%2F7b22726566223a2231643730326439343462383438363031306438613961616632643634663666383932633039313064222c227265706f50617468223a22643a2f646f776e6c6f6164732f62656574732f706c7567696e732f61756469626c65227d%2Fd%3A%2Fdownloads%2Fbeets%2Fplugins%2Faudible%2Faudible.py%3F%7B%5C%22ref%5C%22%3A%5C%221d702d9%5C%22%7D%22%7D "Show More Actions") --- Click to Show Commit

In the past, this used to show when and who the last modification of that line was from.

Unsure if this is a bug with the extension or with Vs Code itself.

Extension version: 12.0.6
VS Code version: Code - Insiders 1.67.0-insider (57fd6d0195bb9b9d1b49f6da5db789060795de47, 2022-05-04T12:03:42.454Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.86GB (5.41GB free)
Process Argv --crash-reporter-id 496947c7-ecc5-4ed0-9d51-bf17cb04032b
Screen Reader yes
VM 0%
@eamodio eamodio self-assigned this Jul 31, 2022
@eamodio eamodio added the bug Something isn't working label Jul 31, 2022
@eamodio eamodio added this to the 12.2 milestone Jul 31, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Jul 31, 2022
@eamodio
Copy link
Member

eamodio commented Jul 31, 2022

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for verification
Projects
None yet
Development

No branches or pull requests

2 participants