Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorship turned on by default for docker compose files #2153

Closed
rtfmoz2 opened this issue Aug 18, 2022 · 5 comments
Closed

Authorship turned on by default for docker compose files #2153

rtfmoz2 opened this issue Aug 18, 2022 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rtfmoz2
Copy link

rtfmoz2 commented Aug 18, 2022

GitLens Version

v12.1.2

VS Code Version

Version: 1.70.2 (Universal)
Commit: e4503b30fc78200f846c62cf8091b76ff5547662
Date: 2022-08-16T05:36:37.829Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin x64 21.6.0

Git Version

git version 2.37.2

Description

Gitlens has authorship turned on for docker compose files by default. Unless my fat fingers toggled it somehow but in two years it has yet to happen. So I had to go into settings and turn it off. Strange behaviour... i figured it came in a update.

Logs, Screenshots, Screen Captures, etc

Screen Shot 2022-08-19 at 7 33 29 am

@rtfmoz2 rtfmoz2 added potential-bug triage Needs to be looked at labels Aug 18, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug labels Apr 11, 2023
@lucasayb
Copy link

Same problem here.

@jkelroy jkelroy added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Apr 25, 2023
@jkelroy

This comment was marked as resolved.

@eamodio eamodio added pending-release Resolved but not yet released to the stable edition and removed needs-more-info Needs further information, steps, details, etc. labels Apr 26, 2023
@eamodio eamodio self-assigned this Apr 26, 2023
@eamodio
Copy link
Member

eamodio commented Apr 26, 2023

GitLens didn't change anything here. My guess is that another extension (Docker?) is now providing language services (symbols, etc) for docker compose files and GitLens is now able to consume them to provide Git CodeLens.

These can be customized per-language, e.g.

"[dockerfile][dockercompose]": {
	"gitlens.codeLens.scopes": [
		"document"
	]
}

That should limit the Git CodeLens to only the document root.

I've also added the above to the GitLens default configuration, so in tomorrow's pre-release this should just work out of the box.

@eamodio eamodio added this to the 13.6 milestone Apr 26, 2023
@eamodio
Copy link
Member

eamodio commented May 1, 2023

Can you please verify this fix in the latest pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label May 13, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants