Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't use scrollbar in 'Commit Graph' view #2381

Closed
Spongman opened this issue Nov 30, 2022 · 4 comments
Closed

can't use scrollbar in 'Commit Graph' view #2381

Spongman opened this issue Nov 30, 2022 · 4 comments
Assignees
Labels
area-graph Issues or features related to the commit graph bug Something isn't working verified ✔ Verified
Milestone

Comments

@Spongman
Copy link

Type: Bug

clicking on the scrollbar in the 'Commit Graph' view causes a click event through to the commit beneath the scrollbar which causess the secondary sidebar to open on the right to that commit, moving the scrollbar and stopping the scroll.

  • open the 'Commit Graph' view (containing a full screen of commits)
  • click on a commit
  • ensure that the commit info pane shows in the secondary sidebar on the right
  • close the secondary sidebar
  • drag the scrollbar in the 'Commit Graph' view:
    • the click goes 'through' the scollbar thumb and clicks the commit underneath
    • the secondary sidebar opens to show that commit
    • the 'Commit Graph' view shrinks to accommodate the secondary sidebar
    • the scrollbar is 'dropped'

Extension version: 13.1.1
VS Code version: Code 1.73.1 (6261075646f055b99068d3688932416f2346dd3b, 2022-11-09T04:27:29.066Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2
Connection to 'ssh-remote+fw.dfcn.com' could not be established
Remote OS version: Linux x64 4.4.0-19041-Microsoft
Remote OS version: Linux x64 3.10.0-957.1.3.el7.x86_64

System Info
Item Value
CPUs Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2904)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: unavailable_off
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) undefined
Memory (System) 47.66GB (5.27GB free)
Process Argv
Screen Reader no
VM 31%
Item Value
Remote WSL: CentOS7
OS Linux x64 5.10.102.1-microsoft-standard-WSL2
CPUs Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2904)
Memory (System) 37.34GB (24.32GB free)
VM 0%
Item Value
Remote WSL: CentOS7
OS Linux x64 5.10.102.1-microsoft-standard-WSL2
CPUs Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2904)
Memory (System) 37.34GB (24.32GB free)
VM 0%

Connection to 'ssh-remote+fw.dfcn.com' could not be established

Item Value
Remote WSL: Ubuntu
OS Linux x64 4.4.0-19041-Microsoft
CPUs Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2901)
Memory (System) 47.66GB (5.40GB free)
VM 31%
Item Value
Remote SSH: dropsy.corp.aetheros.com
OS Linux x64 3.10.0-957.1.3.el7.x86_64
CPUs Intel(R) Xeon(R) CPU X5570 @ 2.93GHz (16 x 1596)
Memory (System) 94.24GB (85.65GB free)
VM 0%
@eamodio eamodio added this to the 13.2 milestone Dec 1, 2022
@eamodio eamodio added bug Something isn't working area-graph Issues or features related to the commit graph labels Dec 1, 2022
@eamodio eamodio closed this as completed in 37c87b8 Dec 2, 2022
@eamodio eamodio self-assigned this Dec 2, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Dec 2, 2022
@eamodio
Copy link
Member

eamodio commented Dec 2, 2022

Can you please verify this fix in tomorrow's pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@axosoft-ramint
Copy link
Contributor

Cannot reproduce on Windows 10 x64 in latest pre-release.

@axosoft-ramint axosoft-ramint added verified ✔ Verified and removed needs-verification Request for verification labels Dec 20, 2022
@Spongman
Copy link
Author

much better, thanks!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-graph Issues or features related to the commit graph bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants