Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable OpenAI/generate commit message #2652

Closed
rognstad opened this issue Apr 26, 2023 · 25 comments
Closed

Add option to disable OpenAI/generate commit message #2652

rognstad opened this issue Apr 26, 2023 · 25 comments
Assignees
Labels
area-ai Issues or features related to AI feature New feature or request verified ✔ Verified
Milestone

Comments

@rognstad
Copy link

Please add an option to disable the "generate commit message" feature and others that send information to OpenAI. Many companies have strict policies regarding the release of IP that this feature potentially violates. Thanks!

@rognstad rognstad added feature New feature or request triage Needs to be looked at labels Apr 26, 2023
@eamodio
Copy link
Member

eamodio commented Apr 26, 2023

Can you provide more details on why a "disable" option is useful? The AI features are not automatic -- they need to be manually triggered through an explicit user action, and then you are prompted to allow the sending of the required information to OpenAI.

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Apr 26, 2023
@rognstad
Copy link
Author

If the option is visible, people are going to be tempted to click on it. The resulting popup has a fair bit of text, and OpenAI isn't mentioned until the fifth line. Plenty of people unwisely reflexively hit enter or proceed through confirmation dialogs. Given an example organization where no one is supposed to send code to AI models, it would be much preferable to disable that option in all of their workspaces than rely on every individual to never make this particular mistake

@eamodio
Copy link
Member

eamodio commented Apr 26, 2023

Gotcha -- thanks for the additional context.

@eamodio eamodio added good first issue Good for newcomers and removed needs-more-info Needs further information, steps, details, etc. labels Apr 26, 2023
@eamodio eamodio added this to the Soon™ milestone Apr 26, 2023
@eamodio eamodio added the area-ai Issues or features related to AI label May 17, 2023
@griffi-gh
Copy link

griffi-gh commented May 30, 2023

i hate AI (especially if "cloud"-based) and hate OpenAI even more.
I want an option that hides all AI features, like "hide all Gitlens+ Features" option.

@JeanTerblanche
Copy link

+1 for a setting for this - and also the Explain this Commit panel below.

A workspace setting will at least provide a mechanism for organizations who wish to limit data sharing with 3rd parties.

In general, having the ability to disable Experimental or GitLens+ features would also be very useful.

image

@griffi-gh
Copy link

griffi-gh commented Jun 2, 2023

@JeanTerblanche :

In general, having the ability to disable Experimental or GitLens+ features would also be very useful.

There's already an option to hide all GL+ features (you can enable only if you don't have the subscription, and after your trial ends. Otherwise (if you have full access to gl+ features), it has no effect)

@DanielPower
Copy link

I certainly won't be subscribing to GitLens if it's going to force these options to be visible.

Many companies (mine included) do not allow the use of unauthorized AI tools that involve uploading of source code for analysis. And that's a very reasonable stance.

You're taking up valuable visual real estate in my editor, for a feature I cannot and do not want to use. And increasing the probability that developers are going to break company security policy.

@griffi-gh
Copy link

I certainly won't be subscribing to GitLens if it's going to force these options to be visible.

the features are free for local and public repos.

you can hide them if you want, just wait for your 14 day trial to expire and then open the command pallete -> Hide GitLens+ features

@michalbielecki
Copy link

I already have GitLens+ features hidden but still see "Explain (AI)" panel in GitLens inspect view

@eamodio
Copy link
Member

eamodio commented Jun 25, 2023

@michalbielecki that's because it's not a restricted/paid feature.

@michalbielecki
Copy link

I was referring to the comment above claiming that disabling paid features would hide AI related stuff

@DanielPower
Copy link

I certainly won't be subscribing to GitLens if it's going to force these options to be visible.

the features are free for local and public repos.

you can hide them if you want, just wait for your 14 day trial to expire and then open the command pallete -> Hide GitLens+ features

I recognize that I can hide them with the option you mentioned on a free plan. However that option does not work on a paid account. Thus my statement that I would not subscribe.

The company has decided to make it so that paying for a subscription makes it impossible to hide this functionality. Thus for me a paid subscription is objectively worse than the free plan. Paying for a subscription would not be a consideration for me until that is addressed.

@CyprusSocialite
Copy link

Can you provide more details on why a "disable" option is useful? The AI features are not automatic -- they need to be manually triggered through an explicit user action, and then you are prompted to allow the sending of the required information to OpenAI.

For screen real estate at the very least. "Explain (AI)" and Autolinks clutter the commit details panel whether you use those features or not - the latter even when completely disabled in settings!

@eamodio
Copy link
Member

eamodio commented Jul 18, 2023

@DanielPower The AI features have nothing to do with free/paid plans at all -- they aren't gated and aren't pro features. This request to hide them is completely valid, but again is completely separate from Pro etc

@eamodio eamodio self-assigned this Nov 5, 2023
@eamodio eamodio removed the good first issue Good for newcomers label Nov 5, 2023
@eamodio eamodio modified the milestones: Soon™, 14.5 Nov 5, 2023
@eamodio eamodio added the pending-release Resolved but not yet released to the stable edition label Nov 5, 2023
@eamodio
Copy link
Member

eamodio commented Nov 5, 2023

@douira The setting name is gitlens.ai.experimental.generateCommitMessage.enabled (note the gitlens. prefix).

@eamodio eamodio closed this as completed Nov 5, 2023
@eamodio
Copy link
Member

eamodio commented Nov 5, 2023

@douira If you were aware of it, why did you post suggesting the setting didn't exist or didn't work?

I added that setting when I added support to contribute to the new button in the SCM input box (41cae89), explicitly for the reason that it highly visible (whereas the existing feature was not) and something that users could definitely want to disable.

vscode-gitlens/package.json

Lines 3080 to 3086 in 8dd2ac6

"gitlens.ai.experimental.generateCommitMessage.enabled": {
"type": "boolean",
"default": true,
"markdownDescription": "Specifies whether to enable GitLens' experimental, AI-powered, on-demand commit message generation",
"scope": "window",
"order": 1
},

@zigomir
Copy link

zigomir commented Nov 6, 2023

@douira The setting name is gitlens.ai.experimental.generateCommitMessage.enabled (note the gitlens. prefix).

this doesn't work for me

My main issue with this AI feature is that I used to be able to type my commit message, hit tab and then hit enter and be done with it. Now after hitting a tab this Generate commit message kicks in and rewrites my commit message – very annoying 😔

@eamodio
Copy link
Member

eamodio commented Nov 7, 2023

@zigomir My guess is that you have Copilot or another extension installed that is also contributing to that button.

@zigomir
Copy link

zigomir commented Nov 7, 2023

@eamodio oh, you're right, I'm sorry for the noise 😊

@kpostekk
Copy link

kpostekk commented Nov 7, 2023

@douira The setting name is gitlens.ai.experimental.generateCommitMessage.enabled (note the gitlens. prefix).

this doesn't work for me

My main issue with this AI feature is that I used to be able to type my commit message, hit tab and then hit enter and be done with it. Now after hitting a tab this Generate commit message kicks in and rewrites my commit message – very annoying 😔

My solution: microsoft/vscode-copilot-release#359 (comment)

@axosoft-ramint axosoft-ramint added verified ✔ Verified and removed pending-release Resolved but not yet released to the stable edition labels Nov 14, 2023
@SampsonCrowley
Copy link

Can you provide more details on why a "disable" option is useful? The AI features are not automatic -- they need to be manually triggered through an explicit user action, and then you are prompted to allow the sending of the required information to OpenAI.

it's also extremely annoying when the button covers part of what I'm typing for a feature I'l never use or be allowed to

@SampsonCrowley
Copy link

Screenshot 2023-11-30 at 10 28 37 AM

@d13
Copy link
Member

d13 commented Nov 30, 2023

it's also extremely annoying when the button covers part of what I'm typing

@SampsonCrowley - its a bug with VS Code (#3034)

@eamodio
Copy link
Member

eamodio commented Nov 30, 2023

You can turn off the GitLens contribution to that button by setting gitlens.ai.experimental.generateCommitMessage.enabled to false

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ai Issues or features related to AI feature New feature or request verified ✔ Verified
Projects
None yet
Development

No branches or pull requests