Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLens hangs on github.dev on Safari #2689

Closed
simonmichael opened this issue May 19, 2023 · 10 comments
Closed

GitLens hangs on github.dev on Safari #2689

simonmichael opened this issue May 19, 2023 · 10 comments
Assignees
Labels
bug Something isn't working support-triaged Support has reviewed, verified, or reproduced this verified ✔ Verified
Milestone

Comments

@simonmichael
Copy link

Description

On github.dev, eg at https://github.dev/github/explore,
after installing GitLens extension,
I click on the GitLens button,
but the pane remains empty, with a spinner, for ever.

Screen Shot 2023-05-19 at 10 38 56

GitLens Version

v2023.5.1805

VS Code Version

No response

Git Version

No response

Logs, Screenshots, Screen Captures, etc

No response

@simonmichael simonmichael added bug Something isn't working triage Needs to be looked at labels May 19, 2023
@jkelroy jkelroy added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels May 22, 2023
@jkelroy
Copy link

jkelroy commented May 22, 2023

Hello @simonmichael, I am not seeing an issue with v2023.5.1805 or any other pre-release version in Google Chrome. What browser and version are you using? Are you able to see if this persists on a different browser and in a private/incognito window?

@simonmichael
Copy link
Author

simonmichael commented May 22, 2023

@jkelroy I see it in Safari 16.2 on mac.

In Brave Version 1.51.118 Chromium: 113.0.5672.126, the GitLens icon does not appear in the activity bar, and there is an error notification:

Error loading webview: Error: Could not register service worker. Please make sure third party cookies are enabled: NotSupportedError: Failed to register a ServiceWorker for scope ('https://1n0ufikvpi4h4vqckld1crj3spao9nr3le81qj3j0dkhic6bf812.vscode-cdn.net/stable/b3e4e68a0bc097f0ae7907b217c1119af9e03435/out/vs/workbench/contrib/webview/browser/pre/') with script ('https://1n0ufikvpi4h4vqckld1crj3spao9nr3le81qj3j0dkhic6bf812.vscode-cdn.net/stable/b3e4e68a0bc097f0ae7907b217c1119af9e03435/out/vs/workbench/contrib/webview/browser/pre/service-worker.js?v=4&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&remoteAuthority='): The user denied permission to use Service Worker.

@simonmichael
Copy link
Author

(but after allowing all cookies and installing the GitLens extension for Brave, it worked as expected.)

@jkelroy jkelroy changed the title hangs on github.dev GitLens hangs on github.dev on Safari May 23, 2023
@jkelroy jkelroy removed the needs-more-info Needs further information, steps, details, etc. label May 23, 2023
@eamodio
Copy link
Member

eamodio commented May 24, 2023

@simonmichael Does only the GitLens Home view "hang"? Do any other GitLens view work? Does the Commit Graph and/or the Welcome (Quick Setup) experiences work?

@eamodio eamodio added the needs-more-info Needs further information, steps, details, etc. label May 24, 2023
@jkelroy
Copy link

jkelroy commented May 25, 2023

@eamodio for me, seemingly nothing in GitLens is working in Safari. Here is what I am doing:

From here on Safari, I cant see any commits/branches/etc, see line blame, or even see the option to open the commit graph:
Screenshot 2023-05-25 at 7 26 39 AM
Screenshot 2023-05-25 at 7 31 43 AM
Screenshot 2023-05-25 at 7 27 02 AM
Screenshot 2023-05-25 at 7 08 47 AM

This is compared to Google Chrome where working with the same repo, everything works as expected:
Screenshot 2023-05-25 at 7 27 21 AM
Screenshot 2023-05-25 at 7 27 38 AM
Screenshot 2023-05-25 at 7 27 14 AM
Screenshot 2023-05-25 at 7 33 29 AM

@github-actions github-actions bot added the inactive Issue has not had recent required feedback label Jun 2, 2023
@jkelroy jkelroy removed needs-more-info Needs further information, steps, details, etc. inactive Issue has not had recent required feedback labels Jun 2, 2023
@gitkraken gitkraken deleted a comment from github-actions bot Jun 2, 2023
@eamodio eamodio self-assigned this Jun 2, 2023
@eamodio eamodio closed this as completed in 6f24a2a Jun 2, 2023
@eamodio eamodio added this to the 13.7 milestone Jun 2, 2023
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Jun 2, 2023
@eamodio
Copy link
Member

eamodio commented Jun 2, 2023

@jkelroy Can you please verify this fix in the 2023.6.03xx (tomorrow's) version of the pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@eamodio
Copy link
Member

eamodio commented Jun 14, 2023

@jkelroy Were you able to verify this?

@jkelroy
Copy link

jkelroy commented Jun 14, 2023

@eamodio I am still seeing the same behavior as described above when using pre-release v2023.6.1405.

@eamodio eamodio reopened this Jun 14, 2023
@eamodio eamodio modified the milestones: 14.0, 14.1 Jun 14, 2023
@eamodio eamodio removed pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Jun 14, 2023
@eamodio eamodio removed their assignment Jun 14, 2023
@eamodio eamodio modified the milestones: 14.1, 14.2 Jul 13, 2023
@jkelroy jkelroy added the support-triaged Support has reviewed, verified, or reproduced this label Jul 18, 2023
@d13 d13 closed this as completed in 49173fe Jul 18, 2023
@eamodio eamodio added the pending-release Resolved but not yet released to the stable edition label Jul 18, 2023
@d13 d13 added the needs-verification Request for verification label Jul 18, 2023
@simonmichael
Copy link
Author

I confirm that switching to the current pre-release of GitLens fixes the issue. Thanks!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Jul 19, 2023
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working support-triaged Support has reviewed, verified, or reproduced this verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

4 participants