Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule commit graph will not open in the panel layout #2728

Closed
jkelroy opened this issue Jun 8, 2023 · 4 comments
Closed

Submodule commit graph will not open in the panel layout #2728

jkelroy opened this issue Jun 8, 2023 · 4 comments
Assignees
Labels
area-graph Issues or features related to the commit graph bug Something isn't working verified ✔ Verified
Milestone

Comments

@jkelroy
Copy link

jkelroy commented Jun 8, 2023

Description

  1. clone this repository https://github.com/jkelroy/main-repo.git and open it in VS Code
  2. In the Source Control view, attempt to open the submodule's commit graph by selecting show commit graph

Expected behavior: The submodules (vscode-gitlens) commit graph is opened

Actual Behavior: The parent repository (main-repo) is opened in the commit graph

This works as expected in the release version (13.6) but does not work in the pre-release (v2023.6.810).

image

GitLens Version

v2023.6.810

VS Code Version

Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T15:00:40.428Z (4 wks ago)
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.3.0
Sandboxed: Yes

Git Version

2.37.1 (Apple Git-137.1)

Logs, Screenshots, Screen Captures, etc

gitlens.txt

open-submodule.mp4
@jkelroy jkelroy added the bug Something isn't working label Jun 8, 2023
@axosoft-ramint axosoft-ramint self-assigned this Jun 9, 2023
@axosoft-ramint axosoft-ramint added the area-graph Issues or features related to the commit graph label Jun 9, 2023
@axosoft-ramint axosoft-ramint added this to the 14.0 milestone Jun 9, 2023
@axosoft-ramint
Copy link
Contributor

The issue seems to be related to the graph being in "Panel" layout.

Image

If you switch the layout to "Editor" layout and then try the repro steps above again, it should open the graph to the correct repo.

@jkelroy jkelroy changed the title Submodule commit graph will not open in the pre-release Submodule commit graph will not open in the panel layout Jun 9, 2023
@jkelroy
Copy link
Author

jkelroy commented Jun 9, 2023

@axosoft-ramint yes, it looks like I cannot view the submodule when its in the panel layout. I updated the title of this issue. Opening in the editor layout works as expected.

Jun-09-2023.13-36-20.mp4

@axosoft-ramint
Copy link
Contributor

Fixed in commit: da288f5

@axosoft-ramint axosoft-ramint added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Jun 13, 2023
@eamodio eamodio added verified ✔ Verified and removed pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Jun 14, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-graph Issues or features related to the commit graph bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants