Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare folder contents among different revisions #3020

Closed
widoz opened this issue Nov 15, 2023 · 8 comments
Closed

Compare folder contents among different revisions #3020

widoz opened this issue Nov 15, 2023 · 8 comments
Assignees
@eamodio
Labels
feature New feature or request verified ✔ Verified
Milestone
14.6

Comments

@widoz
Copy link

widoz commented Nov 15, 2023

In a nutshell, would be nice to have the same Open Changes Menu which appear when selecting a file working with directories.
@widoz widoz added feature New feature or request triage Needs to be looked at labels Nov 15, 2023
@eamodio
Copy link
Member

eamodio commented Nov 15, 2023

Can you please add more detail as I'm not sure I'm understanding the feature request here? Thank you!

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Nov 15, 2023
@widoz
Copy link
Author

widoz commented Nov 16, 2023

Hi there, sure. Sorry if it wasn't clearn enough.

In the screenshot below, you can open the changes for a file and compare it with a Branch or a Tag. But you can't do that for directories.

image

@github-actions github-actions bot added the inactive Issue has not had recent required feedback label Nov 24, 2023
@gitkraken gitkraken deleted a comment from github-actions bot Nov 25, 2023
@eamodio
Copy link
Member

eamodio commented Nov 25, 2023

Thanks, but I'm still not clear on what an action there would do. What would you expect to happen if there was an option for directories?

@github-actions github-actions bot added triage Needs to be looked at and removed inactive Issue has not had recent required feedback labels Nov 26, 2023
@widoz
Copy link
Author

widoz commented Nov 26, 2023

Well, I assume the content of two directories can be compared by Branch, Tag or Revision.

For instance, having a dir module/A I can right click on it and compare the same directory on another branch.

@eamodio eamodio self-assigned this Dec 11, 2023
@eamodio eamodio removed needs-more-info Needs further information, steps, details, etc. triage Needs to be looked at labels Dec 11, 2023
@eamodio eamodio added this to the 14.6 milestone Dec 11, 2023
@eamodio eamodio changed the title Make possible to compare a directory content among different revisions Compare folder contents among different revisions Dec 11, 2023
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Dec 11, 2023
@eamodio
Copy link
Member

eamodio commented Dec 11, 2023

Can you please verify this fix in tomorrow's (v2023.12.11xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@widoz
Copy link
Author

widoz commented Dec 16, 2023

Hi @eamodio

First of all thanks a bunch for the addition, I'm able to see the option for the directories and I can have a view of the multi diff. One thing though, not sure yet if it might be related to a extension conflict, if I select a directory containing multiple directories and level I obtain a list like the following one, where there are some directories named with number even thought them do not exists in my project.

image

More the a conflict with an extension I guess it might be because the file not exists anymore in the current branch.
For instance one of those directories contain the content of a file posts-post-type-controller.tsx I do have in the main (the one using for diff) branch but not in the current one.

@eamodio eamodio mentioned this issue Dec 18, 2023
Open
@eamodio
Copy link
Member

eamodio commented Dec 18, 2023

@widoz Thanks for the report -- I opened #3062 to track it

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Dec 18, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
feature New feature or request verified ✔ Verified
Projects
None yet
Milestone
14.6
Development

No branches or pull requests
2 participants
@eamodio @widoz