Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open in Integrated Terminal option for repository in Repositories section of Source Control tab #3053

Closed
ShadowCreator250 opened this issue Dec 12, 2023 · 3 comments
Assignees
Labels
feature New feature or request verified ✔ Verified
Milestone

Comments

@ShadowCreator250
Copy link

  1. Environment
  • VSCode version
    Version: 1.84.2 (system setup)
    Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
    Date: 2023-11-09T10:51:52.184Z
    Electron: 25.9.2
    ElectronBuildId: 24603566
    Chromium: 114.0.5735.289
    Node.js: 18.15.0
    V8: 11.4.183.29-electron.0
    OS: Windows_NT x64 10.0.19045
    
  • Gitlense version: v14.5.2
  1. Config (the imho relevant ones)
  • "terminal.explorerKind": "integrated"
  • "terminal.external.windowsExec": "C:\\WINDOWS\\System32\\cmd.exe"
  • "terminal.integrated.defaultProfile.windows": "Git Bash"
  • "terminal.sourceControlRepositoriesKind": "integrated"
  1. Reproduce
  • open project with 1 or more repositories
  • ensure you have Gitlens installed
  • go to the Source Control Tab
  • open the Repositories section
  • right click on 1 of the displayed repos
  • click on Open in Terminal
  • (on Windows) a new CMD window opens
    Repositories menu with the "Open in Terminal" option

In the Source Control Repositories section (which I think is VSCode native), an Open in Integrated Terminal option exists.
Source Control Repositories Menu with the "Open in Integrated Terminal" option

Gitlens is usually integrated into VSCode quite well, which leads me to believe that changing the option to use the integrated terminal or adding an option for using the integrated terminal was overlooked.

@ShadowCreator250 ShadowCreator250 added feature New feature or request triage Needs to be looked at labels Dec 12, 2023
@eamodio eamodio self-assigned this Dec 12, 2023
@eamodio eamodio removed the triage Needs to be looked at label Dec 12, 2023
@eamodio eamodio added this to the 14.6 milestone Dec 12, 2023
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Dec 12, 2023
@eamodio
Copy link
Member

eamodio commented Dec 12, 2023

Can you please verify this change in tomorrow's (v2023.12.13xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@ShadowCreator250
Copy link
Author

I just did, it works as expected. Thanks!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Dec 13, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

2 participants