Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icons in GitLens Settings UI #3063

Closed
nickbanana opened this issue Dec 19, 2023 · 5 comments
Closed

Missing icons in GitLens Settings UI #3063

nickbanana opened this issue Dec 19, 2023 · 5 comments
Assignees
@d13
Labels
bug Something isn't working verified ✔ Verified
Milestone
14.6-patch

Comments

@nickbanana
Copy link

Description

collapse/expand icon seems off style, or just could find icon file

GitLens Version

14.6.1

VS Code Version

version: 1.85.1 (user setup)
commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621

Git Version

git version 2.40.0.windows.1

Logs, Screenshots, Screen Captures, etc

image
@nickbanana nickbanana added bug Something isn't working triage Needs to be looked at labels Dec 19, 2023
@eamodio eamodio added this to the 14.6-patch milestone Dec 19, 2023
@d13 d13 removed the triage Needs to be looked at label Dec 19, 2023
@d13 d13 closed this as completed in b33570a Dec 19, 2023
@d13 d13 added the needs-verification Request for verification label Dec 19, 2023
@d13
Copy link
Member

d13 commented Dec 19, 2023

Can you please verify this change in tomorrow's (v2023.12.20xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@nickbanana
Copy link
Author

Can you please verify this change in tomorrow's (v2023.12.20xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

Right now the pre-release version is v2023.12.1904 so the fix isn't exist on said pre-release version right?

@d13
Copy link
Member

d13 commented Dec 20, 2023

Can you please verify this change in tomorrow's (v2023.12.20xx) pre-release edition of GitLens? Thank you so much!
You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.
image

Right now the pre-release version is v2023.12.1904 so the fix isn't exist on said pre-release version right?

Correct, pre-release v2023.12.20xx is not out yet.

@nickbanana
Copy link
Author

Can you please verify this change in tomorrow's (v2023.12.20xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

image
yes the change is live on pre-release v2023.12.2004

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Jan 3, 2024
@eamodio eamodio changed the title missing icon at gitlens setting Missing icons in GitLens Settings UI Jan 17, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@d13 d13

Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Milestone
14.6-patch
Development

No branches or pull requests
3 participants
@d13 @eamodio @nickbanana