Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in package.json and README.md #3116

Closed
yutotnh opened this issue Jan 21, 2024 · 3 comments
Closed

Typos in package.json and README.md #3116

yutotnh opened this issue Jan 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@yutotnh
Copy link
Contributor

yutotnh commented Jan 21, 2024

Description

I found typos in package.json and README.md.

"markdownDescription": "Specifies the locale, a [BCP 47 language tag](https://en.wikipedia.org/wiki/IETF_language_tag#List_of_major_primary_language_subtags), to use for date formatting, defaults to the VS Code locale. Use `system` to follow the current system locale, or choose a specific locale, e.g `en-US` — US English, `en-GB` — British English, `de-DE` — German, 'ja-JP = Japanese, etc.",

- Brandon Cheng ([@gluxon](https://github.com/gluxon)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=gluxon)`

I will submit a pull request for this issue later.

GitLens Version

14.7.0

VS Code Version

Version: 1.85.2 (user setup)
Commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
Date: 2024-01-18T06:40:10.514Z
Electron: 25.9.7
ElectronBuildId: 26354273
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22631

Git Version

git version 2.42.1

Logs, Screenshots, Screen Captures, etc

package.json

image

README.md

image

@yutotnh yutotnh added bug Something isn't working triage Needs to be looked at labels Jan 21, 2024
@jkelroy jkelroy removed the triage Needs to be looked at label Jan 23, 2024
@wiland99
Copy link

Should this issue be closed?

@yutotnh
Copy link
Contributor Author

yutotnh commented Feb 10, 2024

This issue was resolved in #3117.
Therefore, it is closed.

@yutotnh yutotnh closed this as completed Feb 10, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants