Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of #958 for main icon #3206

Closed
grgar opened this issue Mar 29, 2024 · 2 comments
Closed

Regression of #958 for main icon #3206

grgar opened this issue Mar 29, 2024 · 2 comments
Labels
bug Something isn't working duplicate Issue or pull request already exists

Comments

@grgar
Copy link

grgar commented Mar 29, 2024

Description

One icon, the GitLens main editor action icon, does not adapt to the foreground icon colour.

Apart from the main icon, the other icons from #958 still work changing colour.

Versions

GitLens Version

v2024.3.2805 (pre-release)

VS Code Version

Version: 1.88.0-insider
Commit: aa25485166449aa0f9eb8ebd8d0b70376108633c
Date: 2024-03-28T22:11:13.430Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

Git Version

git version 2.44.0

Logs, Screenshots, Screen Captures, etc

With the following in settings.json to highlight the problem

	"workbench.colorCustomizations": {
		"icon.foreground": "#ff0000"

the icons turn red except one:

@grgar grgar added bug Something isn't working triage Needs to be looked at labels Mar 29, 2024
@eamodio
Copy link
Member

eamodio commented Mar 31, 2024

Duplicate of #3143

@eamodio eamodio marked this as a duplicate of #3143 Mar 31, 2024
@eamodio eamodio closed this as completed Mar 31, 2024
@eamodio eamodio added duplicate Issue or pull request already exists and removed triage Needs to be looked at labels Mar 31, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working duplicate Issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants