Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pluralization in Authors lens #3295

Closed
bm-w opened this issue May 15, 2024 · 2 comments
Closed

Incorrect pluralization in Authors lens #3295

bm-w opened this issue May 15, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@bm-w
Copy link
Contributor

bm-w commented May 15, 2024

Description

A little header appears above code blocks that shows the latest change and the authors that have contributed, such as:

Jane Doe, 2 months ago | 4 authors (Jane Doe and others)

When there are only two authors, it still says e.g. “2 authors (Jane Doe and others)” — that should say not say “others”, but e.g. “other” / “another” / “one other”, since when there are two authors and one is named then there is only one other:

Jane Doe, 2 months ago | 2 authors (Jane Doe and one other)

GitLens Version

15.0.3

VS Code Version

Version: 1.88.1
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:43:08.196Z (1 mo ago)
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

Git Version

git version 2.39.3 (Apple Git-146)

Logs, Screenshots, Screen Captures, etc

image
@bm-w bm-w added bug Something isn't working triage Needs to be looked at labels May 15, 2024
@d13 d13 removed the triage Needs to be looked at label May 16, 2024
@d13 d13 added this to the 15.1 milestone May 16, 2024
@d13
Copy link
Member

d13 commented May 31, 2024

Resolved with #3296

@d13 d13 closed this as completed May 31, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants