Change how GitLens runs certain Git commands (e.g. avoid using the terminal)

[eamodio]

Currently GitLens falls back to terminal execution for certain git commands. It was mainly done out of convenience to avoid needing to handle many error cases, but also so that the user could easily tweak the command and execute it again themselves.

We should replace those terminal-run command with custom command like all our other Git commands, though it could still be really nice to offer to open the terminal with the command as an option/button on an error dialog/notification if the user chooses.

Can find all the commands that call this:

vscode-gitlens/src/env/node/git/git.ts

Line 2192 in d9a9718

async runGitCommandViaTerminal(cwd: string, command: string, args: string[], options?: { execute?: boolean }) {

Which really boils down to callers of:

vscode-gitlens/src/git/models/repository.ts

Lines 1289 to 1293 in ac7c727

	private async runTerminalCommand(command: string, ...args: string[]) {
	await this.container.git.runGitCommandViaTerminal?.(this.uri, command, args, { execute: true });
	setTimeout(() => this.fireChange(RepositoryChange.Unknown), 2500);
	}

Tasks

Preview Give feedback

1. Change branch terminal-run commands into normal commands w/ proper error handling #3528
   0 of 1
   debt feature +2
   
2. Change tag terminal-run commands into normal commands w/ proper error handling #3529
   0 of 1
   debt feature verified ✔ +3
   
3. Change reset terminal-run commands into normal commands w/ proper error handling #3533
   0 of 1
   debt feature +2
   
4. Change revert terminal-run commands into normal commands w/ proper error handling #3530
   0 of 1
   debt feature +2
   
5. Change cherry-pick terminal-run commands into normal commands w/ proper error handling #3531
   0 of 1
   debt feature +2
   
6. Change merge terminal-run commands into normal commands w/ proper error handling #3532
   0 of 1
   debt feature +2
   
7. Change rebase terminal-run commands into normal commands w/ proper error handling #3534
   0 of 1
   debt feature +2
   

This will ultimately resolve: #3364, #2889, #2664, #2607, #2541, #2444, #2312, #2057, #1901, #1450, #732, #3364, #1767

[lishaduck]

This sounds really nice!
I assume this was prompted by the VSCode August 2024 release by the filing date, so please disregard this if so, but if not, I'd really love it if the fallback used VSCode's new Terminal shell integration API, as my shell starts up slowly and GitLens's not waiting for the prompt always messes with me :)

Thanks for GitLens! I use it everyday, the commit graph is amazing.