Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make difftool work for any diff #389

Closed
borekb opened this issue May 31, 2018 · 6 comments
Closed

Make difftool work for any diff #389

borekb opened this issue May 31, 2018 · 6 comments
Assignees
Labels
feature New feature or request

Comments

@borekb
Copy link

borekb commented May 31, 2018

VSCode is great for viewing diffs of most files but for example Markdown files with long lines are very hard to make sense of. In such cases, an external diff tool would be very helpful.

GitLens already provides this for uncommitted / staged files since #154 but I'd also like to have it in other "compare" contexts, like browsing a history of a file, the quick pick menus, etc. What do you think?

@eamodio eamodio added the feature New feature or request label Jun 2, 2018
@eamodio eamodio added this to the Soonish™ milestone Jun 2, 2018
@eamodio
Copy link
Member

eamodio commented Jun 2, 2018

Sounds like a great suggestion -- thanks!

@rattrayalex-stripe
Copy link

rattrayalex-stripe commented Jun 7, 2018

We'd also like to be able to view the entire diff in a single editor tab (similar to traditional git diff output, but with VSCode's beautiful side-by-side view). Would that be part of this feature, or best as a separate issue?

@eamodio
Copy link
Member

eamodio commented Jun 7, 2018

@rattrayalex-stripe You can switch vscode into a single editor diff (i.e. inline) today -- it is in the ... menu in the tab bar or via the toggle.diff.editorMode command (but it doesn't seem to be exposed in the command palette).

@rattrayalex-stripe
Copy link

rattrayalex-stripe commented Jun 7, 2018

Oops, sorry for being unclear – I meant viewing the diffs of multiple files in the same editor tab.

For example, if I execute a codemod or find/replace across 100 files, I would like a single tab through which to scroll to verify my changes. For this purpose, I actually quite like the side-by-side view in VSCode.

My hunch is that if VSCode can handle arbitrary diff outputs for display, it can do this.

However, now that I read this issue more carefully, I see that it is roughly the inverse of what I want. EDIT: opened in #404.

Sorry for distracting here.

@eamodio
Copy link
Member

eamodio commented Jun 7, 2018

@rattrayalex-stripe no worries thanks for the clarification

@eamodio eamodio modified the milestones: Soonish™, Soon™ Sep 30, 2018
@eamodio eamodio self-assigned this Sep 30, 2018
@eamodio eamodio closed this as completed in 7e8b404 Dec 2, 2018
@eamodio eamodio removed this from the Soon™ milestone Jul 19, 2019
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants