-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep getting "Session expired" #5
Comments
So you are using Chrome? Go to the extension page in Chrome, enable Developer mode in the top right. Then find the ProtonMail extension there and click on Details. You should see a link at "Inspect views". Click on the background page link. Then developer tools should open and click on Console. You should see the error output, make a screenshot and send it here :) |
I don't think I needed to obfuscate the hashes, but I did it just in case. Here are the requests and responses that keep getting sent repeatedly. If you need any other information, let me know!
|
The extension somehow does not have the permissions to read the cookies or send the cookies with the request (most likely the latter). Which Chromium-based browser are you using? Are you using any special configurations for your browser? I have experienced a similar issue on Firefox, because I have the privacy.firstparty.isolate option enabled. I have forked this repo and added code to work around this issue, but due to the nature of it only the main function, persist session, is working (no notifications). To my knowledge, there is no option like privacy.firstparty.isolate on Chromium. Persisting session should still be possible though whatever the bug might be, so in theory my code could work in your case. But there is no option like privacy.firstparty.isolate that you could check for easily in Chromium like my code does for Firefox. In any case, if you have a bit of experience and want a quick and dirty solution, you could comment the following two lines: https://github.com/gitladen7/protonmail-webextension/blob/master/src/background/services/emailFetcherService.ts#L177 This will prevent the extension from clearing your session, because it thinks it expired (as the request fails, no cookies = no authorization = 401 Unauthorized). You can also enable additional logging output to the console with detailed information by enabling the development mode. You could comment the return here: https://github.com/gitladen7/protonmail-webextension/blob/master/src/background/helpers/logger.ts#L6 |
Ah, this is starting to make sense. I'm using Iridium, a privacy/security-focused browser. I've got DNT enabled and 3rd party cookies disabled. Perhaps that's the issue? I'm not sure how to add an extension to the list of sites that are permitted to store cookies (I assume that would normally be the workaround). Thoughts? Thanks for your prompt response! |
I have just installed Iridium and it works without problems with the extension. DNT/3rd party blocking was enabled by default, and there didn't seem to be other options to harden it even more from the GUI. So that is pretty weird :P |
I think it might be because you use beta protonmail. Can you check on mail.protonmail.com instead? |
Yeah, apparently @gitladen7 just fixed it in his recent commit. Looks like ProtonMail did some changes to their beta version just today. This still doesn't explain why you have had this issue for many days. Wait 1-2 days until the extension was updated in the stores and try again (Chrome store may take a bit longer). Alternatively, it would be good to confirm it works for you on normal mail.protonmail.com with the current version. |
I mainly use the extension to allow the mailto: handler to work, so this isn't a huge issue for me. However, no matter what I do, the plugin shows "ERR" on the icon, and my account shows that the session has expired. I've tried using the beta and mail.protonmail.com but neither makes a difference. I'd be happy to provide more detailed feedback, but I've never debugged a Chrome extension, so . . .
The text was updated successfully, but these errors were encountered: