Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Commit 61b1763

Browse files
author
noah
committed
Fix unit tests
1 parent b926519 commit 61b1763

File tree

2 files changed

+21
-13
lines changed

2 files changed

+21
-13
lines changed

internal/interactor/deployment_test.go

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,13 @@ func TestInteractor_Deploy(t *testing.T) {
5252

5353
store.
5454
EXPECT().
55-
CreateEvent(gomock.Any(), gomock.AssignableToTypeOf(&ent.Event{})).
56-
Return(&ent.Event{}, nil)
55+
CreateEntDeploymentStatus(ctx, gomock.AssignableToTypeOf(&ent.DeploymentStatus{})).
56+
Return(&ent.DeploymentStatus{}, nil)
5757

5858
store.
5959
EXPECT().
60-
CreateEntDeploymentStatus(ctx, gomock.AssignableToTypeOf(&ent.DeploymentStatus{}))
60+
CreateEvent(gomock.Any(), gomock.AssignableToTypeOf(&ent.Event{})).
61+
Return(&ent.Event{}, nil)
6162

6263
it := i.NewInteractor(&i.InteractorConfig{
6364
Store: store,
@@ -99,6 +100,11 @@ func TestInteractor_Deploy(t *testing.T) {
99100
return d, nil
100101
})
101102

103+
store.
104+
EXPECT().
105+
CreateEntDeploymentStatus(ctx, gomock.AssignableToTypeOf(&ent.DeploymentStatus{})).
106+
Return(&ent.DeploymentStatus{}, nil)
107+
102108
store.
103109
EXPECT().
104110
CreateEvent(gomock.Any(), gomock.AssignableToTypeOf(&ent.Event{})).
@@ -160,7 +166,13 @@ func TestInteractor_DeployToRemote(t *testing.T) {
160166

161167
store.
162168
EXPECT().
163-
CreateEntDeploymentStatus(ctx, gomock.AssignableToTypeOf(&ent.DeploymentStatus{}))
169+
CreateEntDeploymentStatus(ctx, gomock.AssignableToTypeOf(&ent.DeploymentStatus{})).
170+
Return(&ent.DeploymentStatus{}, nil)
171+
172+
store.
173+
EXPECT().
174+
CreateEvent(gomock.Any(), gomock.AssignableToTypeOf(&ent.Event{})).
175+
Return(&ent.Event{}, nil)
164176

165177
it := i.NewInteractor(&i.InteractorConfig{
166178
Store: store,

internal/pkg/store/event_test.go

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212

1313
func TestStore_CreateEvent(t *testing.T) {
1414

15-
t.Run("Create a new deleted event", func(t *testing.T) {
15+
t.Run("Create a new deployment_status event", func(t *testing.T) {
1616
ctx := context.Background()
1717

1818
client := enttest.Open(t, "sqlite3", "file:ent?mode=memory&cache=shared&_fk=1",
@@ -22,17 +22,13 @@ func TestStore_CreateEvent(t *testing.T) {
2222

2323
s := NewStore(client)
2424

25-
e, err := s.CreateEvent(ctx, &ent.Event{
26-
Kind: event.KindReview,
27-
Type: event.TypeDeleted,
28-
DeletedID: 1,
25+
_, err := s.CreateEvent(ctx, &ent.Event{
26+
Kind: event.KindDeploymentStatus,
27+
Type: event.TypeCreated,
28+
DeploymentStatusID: 1,
2929
})
3030
if err != nil {
3131
t.Fatalf("CreateEvent returns an error: %s", err)
3232
}
33-
34-
if e.DeletedID != 1 {
35-
t.Fatalf("event.DeletedID = %v, wanted %v", e.DeletedID, 1)
36-
}
3733
})
3834
}

0 commit comments

Comments
 (0)