[dashboard] Request the correct scope when trying to access private repos on GitHub Enterprise

jankeromnes · jankeromnes · commit 0c8391431a51 · 2022-03-04T16:06:16.000Z
diff --git a/components/dashboard/src/start/CreateWorkspace.tsx b/components/dashboard/src/start/CreateWorkspace.tsx
@@ -258,7 +258,7 @@ function RepositoryNotFoundView(p: { error: StartWorkspaceError }) {
       }
 
       // TODO: this should be aware of already granted permissions
-      const missingScope = authProvider.host === 'github.com' ? 'repo' : 'read_repository';
+      const missingScope = authProvider.authProviderType === 'GitHub' ? 'repo' : 'read_repository';
       const authorizeURL = gitpodHostUrl.withApi({
         pathname: '/authorize',
         search: `returnTo=${encodeURIComponent(window.location.toString())}&host=${host}&scopes=${missingScope}`

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ function RepositoryNotFoundView(p: { error: StartWorkspaceError }) {`
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`// TODO: this should be aware of already granted permissions`
`261`		`- const missingScope = authProvider.host === 'github.com' ? 'repo' : 'read_repository';`
	`261`	`+ const missingScope = authProvider.authProviderType === 'GitHub' ? 'repo' : 'read_repository';`
`262`	`262`	`const authorizeURL = gitpodHostUrl.withApi({`
`263`	`263`	`pathname: '/authorize',`
`264`	`264`	search: `returnTo=${encodeURIComponent(window.location.toString())}&host=${host}&scopes=${missingScope}`