[image-builder] Split auth string into only two

Prince Rachit Sinha · Prince Rachit Sinha · commit 2a0c93b4882b · 2022-05-16T07:07:26.000Z
diff --git a/components/image-builder-bob/pkg/proxy/auth.go b/components/image-builder-bob/pkg/proxy/auth.go
@@ -42,7 +42,7 @@ func (a MapAuthorizer) Authorize(host string) (user, pass string, err error) {
 		if err != nil {
 			return
 		}
-		segs := strings.Split(string(auth), ":")
+		segs := strings.SplitN(string(auth), ":", 1)
 		if len(segs) < 2 {
 			return
 		}
diff --git a/components/image-builder-mk3/pkg/auth/auth.go b/components/image-builder-mk3/pkg/auth/auth.go
@@ -207,7 +207,7 @@ func (a AllowedAuthFor) additionalAuth(domain string) *Authentication {
 	}
 	dec, err := base64.StdEncoding.DecodeString(ath)
 	if err == nil {
-		segs := strings.Split(string(dec), ":")
+		segs := strings.SplitN(string(dec), ":", 1)
 		if len(segs) == 2 {
 			res.Username = segs[0]
 			res.Password = segs[1]

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func (a MapAuthorizer) Authorize(host string) (user, pass string, err error) {`
`42`	`42`	`if err != nil {`
`43`	`43`	`return`
`44`	`44`	`}`
`45`		`- segs := strings.Split(string(auth), ":")`
	`45`	`+ segs := strings.SplitN(string(auth), ":", 1)`
`46`	`46`	`if len(segs) < 2 {`
`47`	`47`	`return`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ func (a AllowedAuthFor) additionalAuth(domain string) *Authentication {`
`207`	`207`	`}`
`208`	`208`	`dec, err := base64.StdEncoding.DecodeString(ath)`
`209`	`209`	`if err == nil {`
`210`		`- segs := strings.Split(string(dec), ":")`
	`210`	`+ segs := strings.SplitN(string(dec), ":", 1)`
`211`	`211`	`if len(segs) == 2 {`
`212`	`212`	`res.Username = segs[0]`
`213`	`213`	`res.Password = segs[1]`