Skip to content

Commit 313f48b

Browse files
committed
Remove Prebuild logs from ProjectConfiguration view
1 parent ffe6f48 commit 313f48b

File tree

2 files changed

+13
-142
lines changed

2 files changed

+13
-142
lines changed

components/dashboard/src/projects/ConfigureProject.tsx

+11-140
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,11 @@
55
*/
66

77
import React, { Suspense, useContext, useEffect, useState } from "react";
8-
import { Project, StartPrebuildResult, WorkspaceInstance } from "@gitpod/gitpod-protocol";
9-
import PrebuildLogs from "../components/PrebuildLogs";
8+
import { Project } from "@gitpod/gitpod-protocol";
109
import TabMenuItem from "../components/TabMenuItem";
1110
import { getGitpodService } from "../service/service";
1211
import Spinner from "../icons/Spinner.svg";
1312
import NoAccess from "../icons/NoAccess.svg";
14-
import PrebuildLogsEmpty from "../images/prebuild-logs-empty.svg";
15-
import PrebuildLogsEmptyDark from "../images/prebuild-logs-empty-dark.svg";
16-
import { ThemeContext } from "../theme-context";
17-
import { PrebuildInstanceStatus } from "./Prebuilds";
1813
import { ErrorCodes } from "@gitpod/gitpod-protocol/lib/messaging/error";
1914
import { openAuthorizeWindow } from "../provider-utils";
2015
import { ProjectSettingsPage } from "./ProjectSettings";
@@ -30,15 +25,6 @@ const TASKS = {
3025
echo 'TODO: start app'`,
3126
};
3227

33-
// const IMAGES = {
34-
// Default: 'gitpod/workspace-full',
35-
// '.NET': 'gitpod/workspace-dotnet',
36-
// MongoDB: 'gitpod/workspace-mongodb',
37-
// MySQL: 'gitpod/workspace-mysql',
38-
// PostgreSQL: 'gitpod/workspace-postgres',
39-
// 'Virtual Desktop (VNC)': 'gitpod/workspace-full-vnc',
40-
// }
41-
4228
export default function () {
4329
const { project } = useContext(ProjectContext);
4430
const [gitpodYml, setGitpodYml] = useState<string>("");
@@ -47,11 +33,6 @@ export default function () {
4733
const [selectedEditor, setSelectedEditor] = useState<".gitpod.yml" | ".gitpod.Dockerfile">(".gitpod.yml");
4834
const [isEditorDisabled, setIsEditorDisabled] = useState<boolean>(true);
4935
const [isDetecting, setIsDetecting] = useState<boolean>(true);
50-
const [prebuildWasTriggered, setPrebuildWasTriggered] = useState<boolean>(false);
51-
const [prebuildWasCancelled, setPrebuildWasCancelled] = useState<boolean>(false);
52-
const [startPrebuildResult, setStartPrebuildResult] = useState<StartPrebuildResult | undefined>();
53-
const [prebuildInstance, setPrebuildInstance] = useState<WorkspaceInstance | undefined>();
54-
const { isDark } = useContext(ThemeContext);
5536

5637
const [showAuthBanner, setShowAuthBanner] = useState<{ host: string; scope?: string } | undefined>(undefined);
5738
const [buttonNewWorkspaceEnabled, setButtonNewWorkspaceEnabled] = useState<boolean>(true);
@@ -108,7 +89,7 @@ export default function () {
10889
<EditorMessage
10990
type="warning"
11091
heading="Configuration already exists in git."
111-
message="Run a prebuild or open a new workspace to edit project configuration."
92+
message="Oopen a new workspace to edit project configuration."
11293
/>,
11394
);
11495
setGitpodYml(repoConfigString);
@@ -128,7 +109,7 @@ export default function () {
128109
<EditorMessage
129110
type="success"
130111
heading="Project type detected."
131-
message="You can edit project configuration below before running a prebuild"
112+
message="You can edit project configuration below before starting a workspace."
132113
/>,
133114
);
134115
setGitpodYml(guessedConfigString);
@@ -138,7 +119,7 @@ export default function () {
138119
<EditorMessage
139120
type="warning"
140121
heading="Project type could not be detected."
141-
message="You can edit project configuration below before running a prebuild."
122+
message="You can edit project configuration below before starting a workspace."
142123
/>,
143124
);
144125
setGitpodYml(TASKS.Other);
@@ -176,60 +157,6 @@ export default function () {
176157
});
177158
};
178159

179-
const buildProject = async () => {
180-
if (!project) {
181-
return;
182-
}
183-
setEditorMessage(null);
184-
if (!!startPrebuildResult) {
185-
setStartPrebuildResult(undefined);
186-
}
187-
if (!!prebuildInstance) {
188-
setPrebuildInstance(undefined);
189-
}
190-
try {
191-
setPrebuildWasTriggered(true);
192-
if (!isEditorDisabled) {
193-
await getGitpodService().server.setProjectConfiguration(project.id, gitpodYml);
194-
}
195-
const result = await getGitpodService().server.triggerPrebuild(project.id, null);
196-
setStartPrebuildResult(result);
197-
} catch (error) {
198-
setPrebuildWasTriggered(false);
199-
setEditorMessage(
200-
<EditorMessage
201-
type="warning"
202-
heading="Could not run prebuild."
203-
message={String(error).replace(/Error: Request \w+ failed with message: /, "")}
204-
/>,
205-
);
206-
}
207-
};
208-
209-
const cancelPrebuild = async () => {
210-
if (!project || !startPrebuildResult) {
211-
return;
212-
}
213-
setPrebuildWasCancelled(true);
214-
try {
215-
await getGitpodService().server.cancelPrebuild(project.id, startPrebuildResult.prebuildId);
216-
} catch (error) {
217-
setEditorMessage(
218-
<EditorMessage
219-
type="warning"
220-
heading="Could not cancel prebuild."
221-
message={String(error).replace(/Error: Request \w+ failed with message: /, "")}
222-
/>,
223-
);
224-
} finally {
225-
setPrebuildWasCancelled(false);
226-
}
227-
};
228-
229-
const onInstanceUpdate = (instance: WorkspaceInstance) => {
230-
setPrebuildInstance(instance);
231-
};
232-
233160
useEffect(() => {
234161
document.title = "Configure Project — Gitpod";
235162
}, []);
@@ -244,25 +171,15 @@ export default function () {
244171
window.location.href = url.toString();
245172
};
246173

247-
if (
248-
prebuildInstance?.status.phase === "stopped" &&
249-
!prebuildInstance?.status.conditions.failed &&
250-
!prebuildInstance?.status.conditions.headlessTaskFailed
251-
) {
252-
redirectToNewWorkspace();
253-
return;
254-
}
255-
if (!prebuildWasTriggered) {
256-
await buildProject();
257-
}
258174
redirectToNewWorkspace();
175+
return;
259176
};
260177

261178
return (
262179
<ProjectSettingsPage project={project}>
263180
<div className="grid xl:grid-cols-2 grid-cols-1 gap-4">
264-
<div className="flex-1 h-96 rounded-xl overflow-hidden relative flex flex-col">
265-
<div className="flex bg-gray-50 dark:bg-gray-800 border-b border-gray-200 dark:border-gray-600 px-6 pt-3">
181+
<div className="flex-1 h-96 overflow-hidden relative flex flex-col">
182+
<div className="flex bg-gray-50 dark:bg-gray-800 border-gray-200 dark:border-gray-600 px-6 pt-3">
266183
<TabMenuItem
267184
name=".gitpod.yml"
268185
selected={selectedEditor === ".gitpod.yml"}
@@ -338,56 +255,10 @@ export default function () {
338255
</div>
339256
)}
340257
</div>
341-
<div className="flex-1 h-96 rounded-xl overflow-hidden bg-gray-100 dark:bg-gray-700 flex flex-col">
342-
<div className="flex-grow flex">
343-
{startPrebuildResult ? (
344-
<PrebuildLogs workspaceId={startPrebuildResult.wsid} onInstanceUpdate={onInstanceUpdate} />
345-
) : (
346-
!prebuildWasTriggered && (
347-
<div className="flex-grow flex flex-col items-center justify-center">
348-
<img
349-
alt=""
350-
className="w-14"
351-
role="presentation"
352-
src={isDark ? PrebuildLogsEmptyDark : PrebuildLogsEmpty}
353-
/>
354-
<h3 className="text-center text-lg text-gray-500 dark:text-gray-50 mt-4">
355-
No Recent Prebuild
356-
</h3>
357-
<p className="text-center text-base text-gray-500 dark:text-gray-400 mt-2 w-64">
358-
Edit the project configuration on the left to get started.{" "}
359-
<a className="gp-link" href="https://www.gitpod.io/docs/config-gitpod-file/">
360-
Learn more
361-
</a>
362-
</p>
363-
</div>
364-
)
365-
)}
366-
</div>
367-
<div className="h-20 px-6 bg-gray-50 dark:bg-gray-800 border-t border-gray-200 dark:border-gray-600 flex space-x-2">
368-
{prebuildWasTriggered && <PrebuildInstanceStatus prebuildInstance={prebuildInstance} />}
369-
<div className="flex-grow" />
370-
{prebuildWasTriggered && prebuildInstance?.status.phase !== "stopped" ? (
371-
<button
372-
className="danger flex items-center space-x-2"
373-
disabled={
374-
prebuildWasCancelled ||
375-
(prebuildInstance?.status.phase !== "initializing" &&
376-
prebuildInstance?.status.phase !== "running")
377-
}
378-
onClick={cancelPrebuild}
379-
>
380-
<span>Cancel Prebuild</span>
381-
</button>
382-
) : (
383-
<button disabled={isDetecting} className="secondary" onClick={buildProject}>
384-
Run Prebuild
385-
</button>
386-
)}
387-
<button disabled={isDetecting && buttonNewWorkspaceEnabled} onClick={onNewWorkspace}>
388-
New Workspace
389-
</button>
390-
</div>
258+
<div className="h-20 px-6 bg-gray-50 dark:bg-gray-800 border-gray-200 dark:border-gray-600 flex space-x-2">
259+
<button disabled={isDetecting && buttonNewWorkspaceEnabled} onClick={onNewWorkspace}>
260+
New Workspace
261+
</button>
391262
</div>
392263
</div>
393264
</ProjectSettingsPage>

components/dashboard/src/projects/Prebuild.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import PrebuildLogs from "../components/PrebuildLogs";
1313
import Spinner from "../icons/Spinner.svg";
1414
import { getGitpodService, gitpodHostUrl } from "../service/service";
1515
import { TeamsContext, getCurrentTeam } from "../teams/teams-context";
16-
import { PrebuildInstanceStatus } from "./Prebuilds";
16+
import { PrebuildStatus } from "./Prebuilds";
1717
import { shortCommitMessage } from "./render-utils";
1818

1919
export default function () {
@@ -167,7 +167,7 @@ export default function () {
167167
/>
168168
</div>
169169
<div className="h-20 px-6 bg-gray-50 dark:bg-gray-800 border-t border-gray-200 dark:border-gray-600 flex space-x-2">
170-
{prebuildInstance && <PrebuildInstanceStatus prebuildInstance={prebuildInstance} />}
170+
{prebuildInstance && <PrebuildStatus prebuild={prebuild!} />}
171171
<div className="flex-grow" />
172172
{prebuild?.status === "aborted" || prebuild?.status === "timeout" || !!prebuild?.error ? (
173173
<button

0 commit comments

Comments
 (0)