Skip to content

Commit e06cb09

Browse files
committed
Revert "When using the Latest Release of JetBrains IDEs, if the workspace has tasks defined on .gitpod.yml, the IDE will start with one terminal opened for each task"
This reverts commit 41efa4a.
1 parent 4933c74 commit e06cb09

File tree

14 files changed

+29
-301
lines changed

14 files changed

+29
-301
lines changed

.gitpod.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ tasks:
4646
read -r -p "Press enter to continue Java gradle task"
4747
fi
4848
leeway exec --package components/supervisor-api/java:lib --package components/gitpod-protocol/java:lib -- ./gradlew --build-cache build
49-
leeway exec --package components/ide/jetbrains/backend-plugin:plugin-latest --package components/ide/jetbrains/gateway-plugin:publish --parallel -- ./gradlew --build-cache buildPlugin
49+
leeway exec --package components/ide/jetbrains/backend-plugin:plugin --package components/ide/jetbrains/gateway-plugin:publish --parallel -- ./gradlew --build-cache buildPlugin
5050
- name: TypeScript
5151
before: scripts/branch-namespace.sh
5252
init: yarn --network-timeout 100000 && yarn build

components/ide/jetbrains/backend-plugin/.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,3 @@
33
.vscode
44
bin
55
build
6-
gradle-local.properties
Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
packages:
2-
- name: plugin-stable
2+
- name: plugin
33
type: generic
44
deps:
55
- components/supervisor-api/java:lib
@@ -8,32 +8,11 @@ packages:
88
- "**/*.kt"
99
- "build.gradle.kts"
1010
- "gradle.properties"
11-
- "gradle-stable.properties"
1211
- "gradle/wrapper/*"
1312
- "gradlew"
1413
- "settings.gradle.kts"
1514
- "src/main/resources/*"
16-
- "src/main/resources-stable/*"
1715
config:
1816
commands:
19-
- ["./gradlew", "-PsupervisorApiProjectPath=components-supervisor-api-java--lib/", "-PgitpodProtocolProjectPath=components-gitpod-protocol-java--lib/", "-PenvironmentName=stable", "runPluginVerifier"]
20-
- ["./gradlew", "-PsupervisorApiProjectPath=components-supervisor-api-java--lib/", "-PgitpodProtocolProjectPath=components-gitpod-protocol-java--lib/", "-PenvironmentName=stable", "buildPlugin"]
21-
- name: plugin-latest
22-
type: generic
23-
deps:
24-
- components/supervisor-api/java:lib
25-
- components/gitpod-protocol/java:lib
26-
srcs:
27-
- "**/*.kt"
28-
- "build.gradle.kts"
29-
- "gradle.properties"
30-
- "gradle-latest.properties"
31-
- "gradle/wrapper/*"
32-
- "gradlew"
33-
- "settings.gradle.kts"
34-
- "src/main/resources/*"
35-
- "src/main/resources-latest/*"
36-
config:
37-
commands:
38-
- ["./gradlew", "-PsupervisorApiProjectPath=components-supervisor-api-java--lib/", "-PgitpodProtocolProjectPath=components-gitpod-protocol-java--lib/", "-PenvironmentName=latest", "runPluginVerifier"]
39-
- ["./gradlew", "-PsupervisorApiProjectPath=components-supervisor-api-java--lib/", "-PgitpodProtocolProjectPath=components-gitpod-protocol-java--lib/", "-PenvironmentName=latest", "buildPlugin"]
17+
- ["./gradlew", "-PsupervisorApiProjectPath=components-supervisor-api-java--lib/", "-PgitpodProtocolProjectPath=components-gitpod-protocol-java--lib/", "runPluginVerifier"]
18+
- ["./gradlew", "-PsupervisorApiProjectPath=components-supervisor-api-java--lib/", "-PgitpodProtocolProjectPath=components-gitpod-protocol-java--lib/", "buildPlugin"]

components/ide/jetbrains/backend-plugin/build.gradle.kts

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -10,37 +10,19 @@ fun properties(key: String) = project.findProperty(key).toString()
1010
plugins {
1111
// Java support
1212
id("java")
13-
// Kotlin support - check the latest version at https://plugins.gradle.org/plugin/org.jetbrains.kotlin.jvm
14-
id("org.jetbrains.kotlin.jvm") version "1.7.0"
13+
// Kotlin support
14+
id("org.jetbrains.kotlin.jvm") version "1.5.10"
1515
// gradle-intellij-plugin - read more: https://github.com/JetBrains/gradle-intellij-plugin
16-
id("org.jetbrains.intellij") version "1.6.0"
16+
id("org.jetbrains.intellij") version "1.0"
1717
// detekt linter - read more: https://detekt.github.io/detekt/gradle.html
1818
id("io.gitlab.arturbosch.detekt") version "1.17.1"
1919
// ktlint linter - read more: https://github.com/JLLeitschuh/ktlint-gradle
2020
id("org.jlleitschuh.gradle.ktlint") version "10.0.0"
21-
// Gradle Properties Plugin - read more: https://github.com/stevesaliman/gradle-properties-plugin
22-
id("net.saliman.properties") version "1.5.2"
2321
}
2422

2523
group = properties("pluginGroup")
2624
version = properties("version")
2725

28-
val environmentName = properties("environmentName")
29-
30-
project(":") {
31-
kotlin {
32-
var excludedPackage = "stable"
33-
if (environmentName == excludedPackage) excludedPackage = "latest"
34-
sourceSets["main"].kotlin.exclude("io/gitpod/jetbrains/remote/${excludedPackage}/**")
35-
}
36-
37-
sourceSets {
38-
main {
39-
resources.srcDirs("src/main/resources-${environmentName}")
40-
}
41-
}
42-
}
43-
4426
// Configure project's dependencies
4527
repositories {
4628
mavenCentral()

components/ide/jetbrains/backend-plugin/gradle-latest.properties

Lines changed: 0 additions & 9 deletions
This file was deleted.

components/ide/jetbrains/backend-plugin/gradle-stable.properties

Lines changed: 0 additions & 9 deletions
This file was deleted.

components/ide/jetbrains/backend-plugin/gradle.properties

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
version=0.0.1
2-
# Supported environments: stable, latest (via https://github.com/stevesaliman/gradle-properties-plugin)
3-
environmentName=latest
42
# IntelliJ Platform Artifacts Repositories
53
# -> https://plugins.jetbrains.com/docs/intellij/intellij-artifacts.html
64
pluginGroup=io.gitpod.jetbrains
75
pluginName=gitpod-remote
8-
# IntelliJ Platform Properties -> https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#intellij-extension-type
6+
# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
7+
# for insight into build numbers and IntelliJ Platform versions.
8+
pluginSinceBuild=213
9+
pluginUntilBuild=221.*
10+
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
11+
# See https://jb.gg/intellij-platform-builds-list for available build versions.
12+
pluginVerifierIdeVersions=2021.3, 2022.1
13+
# IntelliJ Platform Properties -> https://github.com/JetBrains/gradle-intellij-plugin#intellij-platform-properties
914
platformType=IU
15+
platformVersion=221-EAP-SNAPSHOT
1016
platformDownloadSources=true
1117
# Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html
1218
# Example: platformPlugins = com.intellij.java, com.jetbrains.php:203.4449.22
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Licensed under the GNU Affero General Public License (AGPL).
33
// See License-AGPL.txt in the project root for license information.
44

5-
package io.gitpod.jetbrains.remote.stable
5+
package io.gitpod.jetbrains.remote
66

77
import com.intellij.openapi.Disposable
88
import com.intellij.openapi.application.runInEdt
@@ -24,7 +24,7 @@ import org.jetbrains.plugins.terminal.TerminalToolWindowFactory
2424
import org.jetbrains.plugins.terminal.TerminalView
2525
import java.util.concurrent.CompletableFuture
2626

27-
@Suppress("UnstableApiUsage", "EXPERIMENTAL_IS_NOT_ENABLED")
27+
@Suppress("UnstableApiUsage", "EXPERIMENTAL_IS_NOT_ENABLED", "OPT_IN_IS_NOT_ENABLED")
2828
@OptIn(DelicateCoroutinesApi::class)
2929
class GitpodTerminalService(private val project: Project) : Disposable {
3030
private val lifetime = Lifetime.Eternal.createNested()

components/ide/jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/latest/GitpodTerminalService.kt

Lines changed: 0 additions & 199 deletions
This file was deleted.

components/ide/jetbrains/backend-plugin/src/main/resources-latest/META-INF/extensions.xml

Lines changed: 0 additions & 10 deletions
This file was deleted.

components/ide/jetbrains/backend-plugin/src/main/resources-stable/META-INF/extensions.xml

Lines changed: 0 additions & 10 deletions
This file was deleted.

components/ide/jetbrains/backend-plugin/src/main/resources/META-INF/plugin.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
Licensed under the GNU Affero General Public License (AGPL).
44
See License-AGPL.txt in the project root for license information.
55
-->
6-
<idea-plugin xmlns:xi="http://www.w3.org/2001/XInclude">
7-
<xi:include href="/META-INF/extensions.xml" xpointer="xpointer(/idea-plugin/*)"/>
86

7+
<idea-plugin>
98
<id>io.gitpod.jetbrains.remote</id>
109
<name>Gitpod Remote</name>
1110
<vendor>Gitpod</vendor>
@@ -27,6 +26,7 @@
2726
<notificationGroup id="Gitpod Notifications" displayType="BALLOON" isLogByDefault="false" />
2827
<httpRequestHandler implementation="io.gitpod.jetbrains.remote.GitpodCLIService"/>
2928
<projectService serviceImplementation="io.gitpod.jetbrains.remote.GitpodClientProjectSessionTracker" client="guest" preload="true"/>
29+
<projectService serviceImplementation="io.gitpod.jetbrains.remote.GitpodTerminalService" preload="true"/>
3030
<projectService serviceImplementation="io.gitpod.jetbrains.remote.GitpodProjectManager" preload="true"/>
3131
<gateway.customization.name implementation="io.gitpod.jetbrains.remote.GitpodGatewayClientCustomizationProvider"/>
3232
</extensions>

0 commit comments

Comments
 (0)