refactor(dashboard/new-project): safety against falsy storedSelectedProviderHost

aboqasem · jankeromnes · aboqasem · commit f310d85b6df1 · 2022-07-10T21:55:38.000+08:00
Co-authored-by: Jan Keromnes &lt;janx@linux.com&gt;
diff --git a/components/dashboard/src/projects/NewProject.tsx b/components/dashboard/src/projects/NewProject.tsx
@@ -62,7 +62,7 @@ export default function NewProject() {
             const authProvider = authProviders.find((p) => p.host === storedSelectedProviderHost);
 
             // if the stored provider exists and is in one of the user's identities, use it
-            if (authProvider && user.identities.some((idt) => idt.authProviderId === authProvider.authProviderId)) {
+            if (storedSelectedProviderHost && authProvider && user.identities.some((idt) => idt.authProviderId === authProvider.authProviderId)) {
                 return setSelectedProviderHost(authProvider.host);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ export default function NewProject() {`
`62`	`62`	`const authProvider = authProviders.find((p) => p.host === storedSelectedProviderHost);`
`63`	`63`
`64`	`64`	`// if the stored provider exists and is in one of the user's identities, use it`
`65`		`- if (authProvider && user.identities.some((idt) => idt.authProviderId === authProvider.authProviderId)) {`
	`65`	`+ if (storedSelectedProviderHost && authProvider && user.identities.some((idt) => idt.authProviderId === authProvider.authProviderId)) {`
`66`	`66`	`return setSelectedProviderHost(authProvider.host);`
`67`	`67`	`}`
`68`	`68`