Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up User Page within Admin Dashboard #10247

Closed
lucasvaltl opened this issue May 25, 2022 · 4 comments
Closed

Clean up User Page within Admin Dashboard #10247

lucasvaltl opened this issue May 25, 2022 · 4 comments

Comments

@lucasvaltl
Copy link
Contributor

lucasvaltl commented May 25, 2022

Context:
The information shown about a user within the admin dashboard > user page is outdated and not relevant for a self-hosted user:
Screenshot 2022-05-25 at 18 53 03

Desired Behaviour:

  • Let's make the admin dashboard work for both SaaS and Self-Hosted. The needs and use cases are likely different, so we need a way to selectively show information
  • We only show information that is relevant to the self-hosted admin on this page.
  • Things like User ID, name, when they joined Gitpod, how many workspaces (instances) they have and actions like blocking and deleting are relevant.
  • Things like Remaining hours, the plan, feature flags, student are not relevant.
  • If we need this information for SaaS, we should find a way to keep it separate from our Self-Hosted users.
@lucasvaltl lucasvaltl changed the title Admin Dashboard improvements Admin Dashboard improvements Specific for Self-Hosted May 25, 2022
@lucasvaltl lucasvaltl moved this from 🧊Backlog to 🤝Proposed in 🚚 Security, Infrastructure, and Delivery Team (SID) May 25, 2022
@lucasvaltl lucasvaltl changed the title Admin Dashboard improvements Specific for Self-Hosted Clean up User Page within Admin Dashboard May 25, 2022
@geropl
Copy link
Member

geropl commented Jul 21, 2022

I agree with the goal (make admin pages useful for Self-Hosted users) but I feel SaaS has a legitimate need as well. 🙃

I'd be even happier if we:

  • could shift the perspective from "not relevant" and "separate" to "how to selectively display data and options based on context (Self-Hosted + SaaS)"
  • frame this request (and others with a similar direction) in the wider context of "Make Admin Dashboard production ready" - because today, it frankly isn't: it's a tool to SaaS operations

If we did the later, we could also think about how we want split up responsibilities, so that each team can contribute, without interfering with others work/requirements. 🧘

@geropl geropl moved this to Clarification in 🍎 WebApp Team Jul 21, 2022
@lucasvaltl
Copy link
Contributor Author

lucasvaltl commented Jul 22, 2022

Fair points - I think the ideal would be to have a clear separation of concerns here (feature flags?), where both SaaS and Self-Hosted Admins have and see what they need :) I'm all for making this work for everyone!

@geropl
Copy link
Member

geropl commented Sep 9, 2022

FYI: There has been a recent change that effectively hides Chargebee/Stripe info + actions for Self-Hosted.
It's based on BillingMode, which is none for Self-Hosted (bad naming is my bad: should be called: license 🙈 ).

Does that help for now @lucasvaltl (cmp. PR for screeshots)

@geropl geropl moved this to Scheduled in 🍎 WebApp Team Sep 12, 2022
@geropl
Copy link
Member

geropl commented Sep 13, 2022

As Lucas is out: What you'll see in Self-Hosted now is this reduced set of properties+actions (only BillingMode will be "none" instead of "usage-based"):

Image

I'm closing for now; we can always re-open later.

Fixed with: #12770

@geropl geropl closed this as completed Sep 13, 2022
Repository owner moved this from Scheduled to Done in 🍎 WebApp Team Sep 13, 2022
@geropl geropl self-assigned this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants