Skip to content

Follow-up from adding the feedback widget on error pages #10307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9 tasks
gtsiolis opened this issue May 27, 2022 · 5 comments
Open
9 tasks

Follow-up from adding the feedback widget on error pages #10307

gtsiolis opened this issue May 27, 2022 · 5 comments
Labels
aspect: tech-debt Issues related to engineering tech debt component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented May 27, 2022

Problem to solve

Following up from #10071, here are some UX issues and side effects we need to address for the feedback widget in the dashboard. Cc @laushinka @andrew-farries @jldec

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team aspect: tech-debt Issues related to engineering tech debt labels May 27, 2022
@laushinka
Copy link
Contributor

Thanks for listing them easily in an issue!

@jldec
Copy link
Contributor

jldec commented Jun 1, 2022

Hi @gtsiolis - are any of the above issues more urgent or higher priority in your opinion ?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jun 1, 2022

@jldec I could pick this up later to fix all the color, alignment, and spacing issues.

The most important outstanding tasks here from UX perspective include the following:

  1. Extra padding and misplaced separator line in the first step (emoji selection) of the modal, which breaks the existing pattern of the modal, see relevant comment and screenshots below.
  2. The layout of the third step (successful submission) of the modal, which looks a bit off, see relevant comment and screenshots below.

However, this does not feel like urgent. Let's put our engineering efforts on other, more important issues. Cc @laushinka

Let me also mark this as a ~good-first-issue in case anyone from the community would like to pick this up.

Modal separator line in variables ✔️ Modal separator line in feedback ❌
Frame 1092 Frame 10923
Successful submission in dashboard pages Successful submission in error pages
Screenshot 2022-05-24 at 5 48 08 PM Screenshot 2022-05-24 at 5 48 13 PM

@stale
Copy link

stale bot commented Sep 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 9, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Sep 9, 2022
@easyCZ easyCZ moved this to Scheduled in 🍎 WebApp Team Sep 27, 2022
@gtsiolis
Copy link
Contributor Author

Added a new follow-up issue about the text overlapping with the feedback emojis:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: tech-debt Issues related to engineering tech debt component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: Scheduled
Development

No branches or pull requests

3 participants