Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-smith] improve performance #10331

Closed
kylos101 opened this issue May 30, 2022 · 2 comments
Closed

[agent-smith] improve performance #10331

kylos101 opened this issue May 30, 2022 · 2 comments
Assignees
Labels
aspect: performance anything related to performance component: agent-smith team: workspace Issue belongs to the Workspace team

Comments

@kylos101
Copy link
Contributor

kylos101 commented May 30, 2022

Is your feature request related to a problem? Please describe

The # of cores used is often high and we believe this might be one of the contributing causes for disconnects in the XL clusters. Not as high as ws-daemon, but is higher than registry-facade. In other words, it is taking CPU that workspaces could be using. Why? Please profile agent-smith, and then check to see if there are opportunities to optimize.

Describe the behaviour you'd like

Max core usage is consistently less. Perhaps less than 2.5?

Describe alternatives you've considered

Less average and max memory used would be ideal, too.

Additional context

Tuning done to improve ws-daemon performance. [1][2]

@kylos101 kylos101 moved this to Scheduled in 🌌 Workspace Team May 30, 2022
@kylos101 kylos101 added team: workspace Issue belongs to the Workspace team aspect: performance anything related to performance labels May 30, 2022
@atduarte
Copy link
Contributor

atduarte commented May 30, 2022

Updated the description to reflect what triggered us to work on this: "we believe this might be one of the contributing causes for disconnects in the XL clusters".

Agent-smith has a lot more work to do on Standard nodes as these have more workspaces running. When looking at the XL clusters at the times of the issues, I don't see high CPU usage: https://grafana.gitpod.io/d/agent-smith/gitpod-component-agent-smith?orgId=1&from=1653552000000&to=1653573600000&var-cluster=us44xl&var-node=All&var-pod=All&var-datasource=VictoriaMetrics&viewPanel=2

@Furisto Furisto self-assigned this May 30, 2022
@Furisto Furisto moved this from Scheduled to In Progress in 🌌 Workspace Team May 30, 2022
@kylos101
Copy link
Contributor Author

kylos101 commented Jun 2, 2022

Resolved in #10356

@kylos101 kylos101 closed this as completed Jun 2, 2022
Repository owner moved this from In Progress to Done in 🌌 Workspace Team Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: performance anything related to performance component: agent-smith team: workspace Issue belongs to the Workspace team
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants